Chore: Code hygiene - warn-numeric-widen #2588
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy HF Kwok <[email protected]>
Signed-off-by: Andy HF Kwok <[email protected]>
Signed-off-by: Andy HF Kwok <[email protected]>
Signed-off-by: Andy HF Kwok <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
============================================
+ Coverage 56.12% 59.30% +3.18%
- Complexity 976 1444 +468
============================================
Files 119 146 +27
Lines 11743 13747 +2004
Branches 2251 2353 +102
============================================
+ Hits 6591 8153 +1562
- Misses 4012 4373 +361
- Partials 1140 1221 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
reviewed
Oct 16, 2025
| <arg>-feature</arg> | ||
| <arg>-Xlint:_</arg> | ||
| <arg>-Ywarn-dead-code</arg> | ||
| <!-- <arg>-deprecation</arg>--> |
There was a problem hiding this comment.
Are these intended changes down here?
comphead
reviewed
Oct 16, 2025
| record.add(0, i % 2 == 0) | ||
| record.add(1, i.toByte) | ||
| record.add(2, i.toShort) | ||
| record.add(1, i.toByte.toInt) |
There was a problem hiding this comment.
its probably can be directly casted to int?
There was a problem hiding this comment.
I believe overflow behaviour will be different and lead to unexpected and incorrect results
comphead
reviewed
Oct 16, 2025
| record.add(0, i % 2 == 0) | ||
| record.add(1, i.toByte) | ||
| record.add(2, i.toShort) | ||
| record.add(1, i.toByte.toInt) |
There was a problem hiding this comment.
same, can be probably converted directly
comphead
reviewed
Oct 16, 2025
| case Some(i) => | ||
| record.add(0, i.toByte) | ||
| record.add(1, i.toShort) | ||
| record.add(0, i.toByte.toInt) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR aims to address the
-Wnumeric-widenwarning in the codebase.As the overall scope of strict-warning compliance is quite large, this change focuses on resolving this specific warning type as a first step. Future PRs will continue addressing other warning incrementally.
Partially closes #. #2255
Rationale for this change
To clean up the code as per static check with the hope to resolve all warning and promote the restrict warning profile for the default CI build to uphold Scala code quality.
What changes are included in this PR?
To perform explicit type conversion instead of relying on runtime implicit cast.
How are these changes tested?
-Wnumeric-widenoption on.