Skip to content

Conversation

@comphead
Copy link
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

* chore: Extend backtrace coverage

* fmt

* part2

* feedback

* clippy

* feat: support Spark `concat`

* clippy

* comments

* test

* doc

(cherry picked from commit 264030c)
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

- Closes #.

Followup on
apache#18063 (review)

## Rationale for this change

Use cheaper `NullBuffer::union` to apply null mask instead of iterator
approach

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

(cherry picked from commit 337378a)
@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) spark labels Oct 17, 2025
@hareshkh hareshkh mentioned this pull request Oct 17, 2025
26 tasks
@alamb alamb changed the title chore: cherry pick concat to 50.3.0 [branch-50]: chore: cherry pick concat to 50.3.0 Oct 17, 2025
@alamb
Copy link
Contributor

alamb commented Oct 18, 2025

Merging to pick up #18141 and try and get a clean CI run

@comphead comphead merged commit ce4eb18 into apache:branch-50 Oct 18, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spark sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants