Fix DISTINCT ON for tables with no columns (ReplaceDistinctWithAggregate: do not fail when on input without columns)
#18133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use LIMIT 1 instead of a GROUP BY in this case: if there are results, they are all empty, we can just take the first one Close apache#18132
alamb
changed the title
DISTINCT ON for tables with no columns (ReplaceDistinctWithAggregate: do not fail when on input without columns)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use LIMIT 1 instead of a GROUP BY in this case: if there are results, they are all empty, we can just take the first one
We cannot use GROUP BY here because GROUP BY requires at least one variable in the grouping side or one aggregation function
DISTINCTfails without columns in thereplace_distinct_aggregaterule #18132