[Fix-16793] WorkerGroupChangeNotifier may can not detect cluster's first time change #16796
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reele
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
ruanwenjun
reviewed
Nov 13, 2024
...c/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerGroupChangeNotifier.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerGroupChangeNotifier.java
Outdated
Show resolved
Hide resolved
...r-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/ClusterManager.java
Outdated
Show resolved
Hide resolved
|
Since we use a daemon thread to detect the worker group changed, so there will always exist delay, but this delay does have a serious effect. We can broadcast a worker group changed event to all masters once the api receive a worker group changed event. |
…ler/server/master/cluster/WorkerGroupChangeNotifier.java Co-authored-by: Wenjun Ruan <[email protected]>
…ler/server/master/cluster/WorkerGroupChangeNotifier.java Co-authored-by: Wenjun Ruan <[email protected]>
…ler/server/master/cluster/ClusterManager.java Co-authored-by: Wenjun Ruan <[email protected]>
SbloodyS
reviewed
Nov 13, 2024
|
formatted |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16793
-- i created a new branch, the old is broken. @SbloodyS
Brief change log
add all groups to new listener when new listener added.
delete
DEFAULT_REFRESH_WORKER_INTERVAL, addstartScheduleThread()to get the parameter fromMasterConfig.add manual call
startScheduleThread()inClusterManager.start()Verify this pull request
Pull Request Notice
Pull Request Notice