[Refactor](inverted index) refactor inverted index file writer for v1/v2 index write #42328
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
airborne12
force-pushed
the
enhance-case
branch
from
869b21f
to
3a622f0
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
airborne12
force-pushed
the
enhance-case
branch
from
3a622f0
to
83c58f1
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run p1 |
|
run cloud_p1 |
airborne12
force-pushed
the
enhance-case
branch
from
83c58f1
to
2ec92d9
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| namespace doris { | ||
| namespace segment_v2 { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespace doris { | |
| namespace segment_v2 { | |
| namespace doris::segment_v2 { |
be/test/olap/rowset/segment_v2/inverted_index_file_writer_test.cpp:377:
- } // namespace segment_v2
- } // namespace doris
+ } // namespace doris
airborne12
force-pushed
the
enhance-case
branch
from
a26c622
to
178ec5e
Compare
|
run buildall |
| namespace doris { | ||
| namespace segment_v2 { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespace doris { | |
| namespace segment_v2 { | |
| namespace doris::segment_v2 { |
be/test/olap/rowset/segment_v2/inverted_index_file_writer_test.cpp:424:
- } // namespace segment_v2
- } // namespace doris
+ } // namespace doris
airborne12
force-pushed
the
enhance-case
branch
from
178ec5e
to
ef11c84
Compare
|
run buildall |
airborne12
force-pushed
the
enhance-case
branch
from
ef11c84
to
397fa45
Compare
|
run buildall |
airborne12
force-pushed
the
enhance-case
branch
from
397fa45
to
dc539c3
Compare
|
run buildall |
| namespace doris { | ||
| namespace segment_v2 { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespace doris { | |
| namespace segment_v2 { | |
| namespace doris::segment_v2 { |
be/test/olap/rowset/segment_v2/inverted_index_file_writer_test.cpp:509:
- } // namespace segment_v2
- } // namespace doris
+ } // namespace doris
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
airborne12
force-pushed
the
enhance-case
branch
from
8202c5a
to
ab8b8fe
Compare
|
run buildall |
| namespace doris { | ||
| namespace segment_v2 { |
There was a problem hiding this comment.
warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
| namespace doris { | |
| namespace segment_v2 { | |
| namespace doris::segment_v2 { |
be/test/olap/rowset/segment_v2/inverted_index_file_writer_test.cpp:513:
- } // namespace segment_v2
- } // namespace doris
+ } // namespace doris
|
TeamCity be ut coverage result: |
|
run buildall |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Proposed changes
The original write_v1 and write_v2 methods in the inverted index file writer were overly long and difficult to maintain. This PR refactors these methods to improve code maintainability and readability.