Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement](checker) Enhance inverted checker #43294

Merged
merged 3 commits into from
Nov 14, 2024
Merged

[Enhancement](checker) Enhance inverted checker #43294

merged 3 commits into from
Nov 14, 2024
+72 −28

Conversation

Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.74% (9814/26003)
Line Coverage: 29.05% (82112/282687)
Region Coverage: 28.15% (42198/149902)
Branch Coverage: 24.73% (21388/86472)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c0e85f9c415a144cd2b61d207cd6ec9a7e706d8e_c0e85f9c415a144cd2b61d207cd6ec9a7e706d8e/report/index.html

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run cloud_p0

@Yukang-Lian
Copy link
Collaborator Author

run beut

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

gavinchou
gavinchou previously approved these changes Nov 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024
@Yukang-Lian
Copy link
Collaborator Author

run beut

4 similar comments
@Yukang-Lian
Copy link
Collaborator Author

run beut

@Yukang-Lian
Copy link
Collaborator Author

run beut

@Yukang-Lian
Copy link
Collaborator Author

run beut

@Yukang-Lian
Copy link
Collaborator Author

run beut

@gavinchou
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run cloud_p0

@Yukang-Lian
Copy link
Collaborator Author

run buildall

1 similar comment
@Yukang-Lian
Copy link
Collaborator Author

run buildall

@gavinchou gavinchou mentioned this pull request Nov 13, 2024
Merged
gavinchou pushed a commit that referenced this pull request Nov 13, 2024
@Yukang-Lian
[cherry-pick](branch-3.0) Pick "[Enhancement](checker) Enhance invert…
2658ac8 
…ed checker (#43294)" (#43869)
@gavinchou
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.94% (9888/26063)
Line Coverage: 29.13% (82617/283618)
Region Coverage: 28.27% (42476/150256)
Branch Coverage: 24.85% (21543/86696)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2853556ebd70088e6315339e2769570fbcc91b4b_2853556ebd70088e6315339e2769570fbcc91b4b/report/index.html

@gavinchou gavinchou merged commit 472f0de into apache:master Nov 14, 2024
24 of 26 checks passed
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luwei16 luwei16 luwei16 approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yukang-Lian @doris-robot @gavinchou @luwei16