-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](mtmv) Fix generate hyper graph wrongly when has filter which can not push down #43539
[fix](mtmv) Fix generate hyper graph wrongly when has filter which can not push down #43539
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
TPC-H: Total hot run time: 52043 ms
|
run performance |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
@@ -801,6 +803,8 @@ protected SplitPredicate predicatesCompensate( | |||
private boolean containsNullRejectSlot(Set<Set<Slot>> requireNoNullableViewSlot, | |||
Set<Expression> queryPredicates, | |||
SlotMapping queryToViewMapping, | |||
StructInfo queryStructInfo, | |||
StructInfo viwStructInfo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viwStructInfo -> viewStructInfo
run buildall |
PR approved by at least one committer and no changes requested. |
…n not push down (#43539) ### What problem does this PR solve? Related PR: #28006 Problem Summary: When query is as following: select o_orderdate, o_shippriority, o_comment, l_orderkey, l_partkey from orders left join lineitem on l_orderkey = o_orderkey left join partsupp on ps_partkey = l_partkey and l_suppkey = ps_suppkey; hyper graph is as following: this` leftExtendedNodes` Shoule be contained both orders and lineitem, which should be 3, but now is 2 This may cause associate wrongly when use hyper graph and materialized view which depends on it rewrite wrongly ### Release note Fix generate hyper graph wrongly when has filter which can not push down
…n not push down (#43539) ### What problem does this PR solve? Related PR: #28006 Problem Summary: When query is as following: select o_orderdate, o_shippriority, o_comment, l_orderkey, l_partkey from orders left join lineitem on l_orderkey = o_orderkey left join partsupp on ps_partkey = l_partkey and l_suppkey = ps_suppkey; hyper graph is as following: this` leftExtendedNodes` Shoule be contained both orders and lineitem, which should be 3, but now is 2 This may cause associate wrongly when use hyper graph and materialized view which depends on it rewrite wrongly ### Release note Fix generate hyper graph wrongly when has filter which can not push down
…ter which can not push down #43539 (#43944) Cherry-picked from #43539 Co-authored-by: seawinde <[email protected]>
What problem does this PR solve?
When query is as following:
hyper graph is as following:
this
leftExtendedNodes
Shoule be contained both orders and lineitem, which should be 3, but now is 2Issue Number: close #xxx
Related PR: #28006
Problem Summary:
This may cause associate wrongly when use hyper graph and materialized view which depends on it rewrite wrongly
Release note
Fix generate hyper graph wrongly when has filter which can not push down
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)