Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](variant) fix index in variant (#43375) #43971

Open
wants to merge 1 commit into
base: branch-2.1
Choose a base branch
from
Open

[fix](variant) fix index in variant (#43375) #43971

wants to merge 1 commit into from

Conversation

csun5285
Copy link
Contributor

Problem Summary:

  1. Fixing error checks, InvertedIndexColumnWriter::check_support_inverted_index, It is not appropriate to determine support for other indexes by checking the inverted index.
  2. Fix TableSchema::update_index()

pick from master #43375

@csun5285
[fix](variant) fix index in variant (apache#43375)
0a5c0de 
Problem Summary:

1. Fixing error checks,
`InvertedIndexColumnWriter::check_support_inverted_index`, It is not
appropriate to determine support for other indexes by checking the
inverted index.
2. Fix `TableSchema::update_index()`

Co-authored-by: csun5285 <[email protected]>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/common/schema_util_test.cpp
// specific language governing permissions and limitations
// under the License.

#include "vec/common/schema_util.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'vec/common/schema_util.h' file not found [clang-diagnostic-error]

#include "vec/common/schema_util.h"
         ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csun5285 @doris-robot