Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Fix](auto-increment) Fix duplicate auto-increment column value problem #43774 #43983

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Commits on Nov 14, 2024

  1. [Fix](auto-increment) Fix duplicate auto-increment column value probl…

    …em (#43774)
    
    ```cpp
    Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
        // ...
        return _rpc_status;
    }
    ```
    should be
    ```cpp
    Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
        // ...
        return ResultError(_rpc_status);
    }
    ```
    Otherwise, the returned `Result<int64_t>`'s `m_has_val` will be `true`,
    then `AutoIncIDBuffer::_launch_async_fetch_task()` will wrongly add an
    auto-increment range [0, length) to `_buffers` which will cause
    duplicate value problem.
    
    ### Release note
    
    Fix duplicate auto-increment column value problem in some situations.
    bobhan1 authored and Your Name committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8cbd45e View commit details
    Browse the repository at this point in the history