Skip to content

[fix](nereids)create alias function should fail when meet unsupported expr #49698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix](nereids)create alias function should fail when meet unsupported expr #49698

wants to merge 1 commit into from

Conversation

starocean999
Copy link
Contributor

What problem does this PR solve?

before this pr, the bellow create alias function command would succeed, but it should fail in nereids.
create GLOBAL ALIAS FUNCTION userlevel(bigint) with PARAMETER(level_score) as (CASE WHEN level_score < 0 THEN 0 WHEN level_score < 1000 THEN 1 WHEN level_score < 5000 THEN 2 WHEN level_score < 10000 THEN 3 WHEN level_score < 407160000 THEN 29 ELSE 30 END);

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33969 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3d53c88d1fe15b887299d052f26617e69565bba4, data reload: false

------ Round 1 ----------------------------------
q1	25517	5074	4984	4984
q2	2073	299	172	172
q3	10377	1224	684	684
q4	10227	986	517	517
q5	7553	2355	2287	2287
q6	187	161	129	129
q7	910	716	606	606
q8	9301	1305	1036	1036
q9	6809	5144	5043	5043
q10	6859	2297	1904	1904
q11	470	289	260	260
q12	353	339	219	219
q13	17771	3637	3160	3160
q14	221	222	207	207
q15	525	494	478	478
q16	640	626	602	602
q17	572	848	338	338
q18	7465	7276	7209	7209
q19	1535	1093	583	583
q20	322	330	194	194
q21	3906	2600	2358	2358
q22	1055	1038	999	999
Total cold run time: 114648 ms
Total hot run time: 33969 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5171	5130	5105	5105
q2	236	322	238	238
q3	2165	2695	2247	2247
q4	1423	1786	1375	1375
q5	4388	4300	4369	4300
q6	211	172	127	127
q7	1938	1925	1752	1752
q8	2623	2529	2643	2529
q9	7194	7203	6964	6964
q10	3059	3163	2742	2742
q11	567	492	509	492
q12	678	769	613	613
q13	3580	3867	3258	3258
q14	283	301	270	270
q15	520	479	499	479
q16	669	681	654	654
q17	1127	1568	1367	1367
q18	7691	7535	7396	7396
q19	811	809	863	809
q20	2023	2053	1852	1852
q21	5187	4841	4749	4749
q22	1099	1064	1016	1016
Total cold run time: 52643 ms
Total hot run time: 50334 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193084 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3d53c88d1fe15b887299d052f26617e69565bba4, data reload: false

query1	1425	1079	1038	1038
query2	6332	1887	1909	1887
query3	11134	4621	4645	4621
query4	25360	24047	23784	23784
query5	5377	683	490	490
query6	347	206	186	186
query7	3979	494	271	271
query8	305	246	223	223
query9	8515	2577	2577	2577
query10	504	304	252	252
query11	15426	15229	14928	14928
query12	165	111	109	109
query13	1569	522	396	396
query14	8858	6191	6189	6189
query15	207	185	176	176
query16	7230	639	489	489
query17	1185	770	602	602
query18	2096	421	339	339
query19	207	207	189	189
query20	133	123	129	123
query21	212	128	112	112
query22	4537	4669	4337	4337
query23	34125	33563	33414	33414
query24	8691	2416	2394	2394
query25	509	458	424	424
query26	799	273	146	146
query27	3183	535	327	327
query28	4833	2439	2431	2431
query29	661	577	452	452
query30	273	221	206	206
query31	883	844	776	776
query32	67	66	64	64
query33	554	360	317	317
query34	776	874	526	526
query35	842	842	803	803
query36	971	999	903	903
query37	131	104	79	79
query38	4139	4164	4062	4062
query39	1503	1497	1438	1438
query40	206	119	118	118
query41	56	53	54	53
query42	125	108	105	105
query43	508	508	496	496
query44	1313	806	808	806
query45	182	175	167	167
query46	846	1034	657	657
query47	1866	1920	1801	1801
query48	376	425	321	321
query49	761	518	429	429
query50	687	783	427	427
query51	4243	4296	4276	4276
query52	105	109	101	101
query53	226	254	186	186
query54	492	503	422	422
query55	90	82	84	82
query56	293	273	320	273
query57	1184	1216	1093	1093
query58	256	259	242	242
query59	2613	2847	2675	2675
query60	291	289	278	278
query61	135	134	132	132
query62	773	717	661	661
query63	224	179	186	179
query64	3149	1050	697	697
query65	4413	4377	4379	4377
query66	796	395	290	290
query67	16392	15486	15175	15175
query68	9606	874	509	509
query69	548	309	257	257
query70	1227	1110	1083	1083
query71	476	300	275	275
query72	5245	4702	4688	4688
query73	712	559	349	349
query74	8944	9114	8718	8718
query75	4547	3226	2731	2731
query76	4217	1201	769	769
query77	998	386	281	281
query78	9964	10157	9284	9284
query79	1632	826	552	552
query80	657	528	475	475
query81	478	252	222	222
query82	371	126	103	103
query83	202	176	165	165
query84	280	100	80	80
query85	741	425	309	309
query86	328	316	282	282
query87	4456	4474	4416	4416
query88	2793	2248	2262	2248
query89	377	303	285	285
query90	1928	209	215	209
query91	150	138	120	120
query92	69	60	61	60
query93	1173	1062	582	582
query94	667	428	308	308
query95	340	281	262	262
query96	488	563	273	273
query97	3150	3200	3111	3111
query98	240	209	203	203
query99	1421	1443	1276	1276
Total cold run time: 279069 ms
Total hot run time: 193084 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3d53c88d1fe15b887299d052f26617e69565bba4, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.10
query3	0.25	0.19	0.18
query4	1.60	0.20	0.20
query5	0.58	0.58	0.58
query6	1.19	0.72	0.72
query7	0.02	0.03	0.02
query8	0.05	0.04	0.03
query9	0.57	0.52	0.52
query10	0.61	0.59	0.57
query11	0.16	0.12	0.11
query12	0.14	0.12	0.11
query13	0.62	0.59	0.61
query14	2.66	2.74	2.70
query15	0.92	0.85	0.86
query16	0.39	0.40	0.38
query17	1.03	1.02	1.01
query18	0.21	0.20	0.19
query19	1.96	1.95	1.98
query20	0.02	0.01	0.01
query21	15.36	0.94	0.56
query22	0.74	1.24	0.68
query23	14.92	1.38	0.63
query24	7.10	1.35	0.95
query25	0.54	0.10	0.08
query26	0.61	0.16	0.13
query27	0.05	0.06	0.05
query28	9.62	0.88	0.45
query29	12.52	4.06	3.35
query30	0.25	0.09	0.07
query31	2.84	0.58	0.38
query32	3.22	0.54	0.47
query33	2.99	3.03	3.13
query34	15.74	5.14	4.51
query35	4.54	4.52	4.58
query36	0.68	0.48	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 105.37 s
Total hot run time: 31.51 s

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34315 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e8d3b773870b3a4d03d6a3bce8871a03ec9fd54e, data reload: false

------ Round 1 ----------------------------------
q1	25884	5042	4972	4972
q2	2079	284	182	182
q3	10382	1233	701	701
q4	10232	998	534	534
q5	7548	2403	2402	2402
q6	180	162	131	131
q7	882	735	601	601
q8	9307	1287	1124	1124
q9	6784	5142	5073	5073
q10	6808	2309	1934	1934
q11	478	290	288	288
q12	339	350	219	219
q13	17754	3677	3110	3110
q14	229	236	207	207
q15	521	496	478	478
q16	635	618	602	602
q17	579	852	371	371
q18	7696	7183	7241	7183
q19	1154	932	562	562
q20	347	333	229	229
q21	4037	3364	2449	2449
q22	1043	1032	963	963
Total cold run time: 114898 ms
Total hot run time: 34315 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5096	5047	5083	5047
q2	247	328	232	232
q3	2147	2632	2311	2311
q4	1437	1840	1396	1396
q5	4547	4453	4383	4383
q6	210	178	125	125
q7	1973	1873	1681	1681
q8	2597	2523	2510	2510
q9	7335	7167	7329	7167
q10	2971	3198	2705	2705
q11	563	502	482	482
q12	703	765	597	597
q13	3548	3892	3259	3259
q14	312	306	264	264
q15	520	486	470	470
q16	640	682	657	657
q17	1141	1542	1397	1397
q18	7721	7504	7560	7504
q19	1199	875	957	875
q20	1976	2057	1852	1852
q21	5192	4722	4623	4623
q22	1072	1014	978	978
Total cold run time: 53147 ms
Total hot run time: 50515 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186197 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e8d3b773870b3a4d03d6a3bce8871a03ec9fd54e, data reload: false

query1	1048	506	468	468
query2	6542	1939	2003	1939
query3	6750	229	216	216
query4	26004	23179	22942	22942
query5	4338	623	458	458
query6	322	207	194	194
query7	4625	490	294	294
query8	307	249	237	237
query9	8647	2532	2528	2528
query10	487	324	269	269
query11	15479	14942	14780	14780
query12	178	107	104	104
query13	1662	531	407	407
query14	9500	6039	6069	6039
query15	203	189	169	169
query16	7681	647	468	468
query17	1189	739	591	591
query18	2051	409	314	314
query19	202	200	165	165
query20	127	129	125	125
query21	215	123	106	106
query22	4093	4292	4307	4292
query23	33918	33086	33062	33062
query24	8421	2375	2351	2351
query25	515	432	382	382
query26	1239	265	146	146
query27	2741	517	318	318
query28	4325	2408	2393	2393
query29	710	558	422	422
query30	285	223	195	195
query31	975	869	754	754
query32	69	67	62	62
query33	565	397	313	313
query34	767	849	502	502
query35	790	819	751	751
query36	955	976	887	887
query37	121	102	73	73
query38	4164	4204	4072	4072
query39	1453	1502	1401	1401
query40	210	119	105	105
query41	56	51	50	50
query42	118	103	107	103
query43	489	480	481	480
query44	1254	775	782	775
query45	175	172	165	165
query46	812	1018	606	606
query47	1789	1808	1749	1749
query48	368	409	325	325
query49	778	517	418	418
query50	638	685	385	385
query51	4298	4145	4122	4122
query52	106	101	101	101
query53	218	248	177	177
query54	580	553	499	499
query55	82	78	87	78
query56	303	344	288	288
query57	1123	1139	1119	1119
query58	259	256	277	256
query59	2680	2706	2699	2699
query60	317	315	291	291
query61	135	126	126	126
query62	817	723	652	652
query63	219	185	193	185
query64	4280	995	690	690
query65	4378	4219	4239	4219
query66	1065	418	306	306
query67	15873	15663	15370	15370
query68	8494	874	502	502
query69	465	314	264	264
query70	1190	1064	1111	1064
query71	511	316	292	292
query72	5456	4684	4557	4557
query73	710	554	342	342
query74	8899	9160	9100	9100
query75	3953	3238	2676	2676
query76	3700	1186	738	738
query77	788	383	287	287
query78	10018	10174	9211	9211
query79	4332	797	554	554
query80	669	515	434	434
query81	490	258	222	222
query82	583	127	98	98
query83	299	252	230	230
query84	301	109	90	90
query85	791	436	311	311
query86	393	293	272	272
query87	4463	4494	4525	4494
query88	3472	2238	2262	2238
query89	439	312	287	287
query90	1951	210	210	210
query91	142	137	108	108
query92	79	62	54	54
query93	3218	935	583	583
query94	679	416	293	293
query95	377	295	294	294
query96	482	579	280	280
query97	3185	3217	3088	3088
query98	236	207	200	200
query99	1422	1418	1296	1296
Total cold run time: 279270 ms
Total hot run time: 186197 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e8d3b773870b3a4d03d6a3bce8871a03ec9fd54e, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.10
query3	0.24	0.20	0.19
query4	1.60	0.18	0.20
query5	0.60	0.56	0.57
query6	1.20	0.72	0.73
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.53	0.54
query10	0.58	0.59	0.56
query11	0.16	0.11	0.10
query12	0.15	0.11	0.11
query13	0.61	0.59	0.60
query14	2.70	2.82	2.70
query15	0.92	0.85	0.85
query16	0.38	0.38	0.37
query17	1.04	1.02	1.01
query18	0.20	0.20	0.19
query19	1.89	2.03	1.84
query20	0.02	0.01	0.02
query21	15.70	0.89	0.53
query22	0.85	1.17	0.72
query23	15.31	1.40	0.61
query24	7.06	1.49	0.56
query25	0.49	0.09	0.06
query26	0.54	0.17	0.15
query27	0.05	0.06	0.05
query28	9.80	0.88	0.43
query29	12.55	3.92	3.28
query30	0.25	0.09	0.06
query31	2.83	0.62	0.40
query32	3.23	0.54	0.46
query33	3.02	3.01	3.11
query34	15.75	5.09	4.46
query35	4.50	4.51	4.50
query36	0.66	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.16	0.14	0.13
query41	0.07	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.17 s
Total hot run time: 30.77 s

@starocean999
Copy link
Contributor Author

run builldall

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34158 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f45537674436f40f19e1a5bc289bf655963903c9, data reload: false

------ Round 1 ----------------------------------
q1	26073	5096	4981	4981
q2	2067	279	183	183
q3	10391	1233	676	676
q4	10240	1019	530	530
q5	7544	2290	2377	2290
q6	185	165	135	135
q7	908	747	606	606
q8	9312	1234	1092	1092
q9	6857	5126	5133	5126
q10	6804	2298	1908	1908
q11	461	290	269	269
q12	353	362	217	217
q13	17754	3659	3107	3107
q14	227	239	207	207
q15	538	486	474	474
q16	617	597	583	583
q17	595	867	380	380
q18	7497	7278	7113	7113
q19	1213	938	579	579
q20	342	340	232	232
q21	4057	3391	2494	2494
q22	1055	1018	976	976
Total cold run time: 115090 ms
Total hot run time: 34158 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5074	5107	5042	5042
q2	235	324	232	232
q3	2143	2635	2279	2279
q4	1438	1826	1421	1421
q5	4506	4478	4379	4379
q6	206	166	125	125
q7	1980	1949	1740	1740
q8	2570	2569	2494	2494
q9	7169	7098	7254	7098
q10	2965	3185	2723	2723
q11	561	497	496	496
q12	691	749	618	618
q13	3446	3871	3263	3263
q14	266	308	271	271
q15	529	469	463	463
q16	684	679	662	662
q17	1163	1601	1305	1305
q18	7710	7461	7466	7461
q19	800	770	831	770
q20	1978	2023	1869	1869
q21	5175	4647	4595	4595
q22	1029	1012	995	995
Total cold run time: 52318 ms
Total hot run time: 50301 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185782 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f45537674436f40f19e1a5bc289bf655963903c9, data reload: false

query1	990	508	467	467
query2	6561	1982	1929	1929
query3	6749	222	229	222
query4	26164	23718	22861	22861
query5	4364	621	480	480
query6	301	218	194	194
query7	4631	486	289	289
query8	297	253	235	235
query9	8625	2610	2585	2585
query10	463	333	258	258
query11	15428	15121	14745	14745
query12	160	107	106	106
query13	1664	509	371	371
query14	8793	6021	6082	6021
query15	195	192	166	166
query16	7169	578	451	451
query17	1195	711	565	565
query18	1982	412	309	309
query19	195	183	163	163
query20	122	119	117	117
query21	216	124	103	103
query22	4147	4381	4300	4300
query23	33682	32945	33158	32945
query24	8425	2378	2367	2367
query25	561	480	410	410
query26	1240	269	153	153
query27	2756	514	331	331
query28	4316	2436	2382	2382
query29	801	585	443	443
query30	286	229	196	196
query31	899	840	800	800
query32	77	68	69	68
query33	575	374	385	374
query34	783	838	507	507
query35	766	794	737	737
query36	963	985	887	887
query37	127	97	76	76
query38	4065	4107	3944	3944
query39	1473	1394	1370	1370
query40	213	118	105	105
query41	56	54	54	54
query42	120	107	102	102
query43	483	491	511	491
query44	1263	783	783	783
query45	177	172	165	165
query46	824	988	612	612
query47	1743	1817	1727	1727
query48	368	415	301	301
query49	781	511	439	439
query50	619	669	390	390
query51	4172	4175	4111	4111
query52	109	104	95	95
query53	221	248	187	187
query54	576	569	496	496
query55	88	78	79	78
query56	295	303	289	289
query57	1131	1120	1101	1101
query58	272	255	257	255
query59	2795	2844	2792	2792
query60	328	324	301	301
query61	130	147	131	131
query62	785	749	634	634
query63	218	184	179	179
query64	4513	1048	796	796
query65	4308	4281	4160	4160
query66	1144	416	312	312
query67	16345	15898	15386	15386
query68	9416	825	502	502
query69	485	302	269	269
query70	1193	1137	1006	1006
query71	461	311	301	301
query72	5782	4729	4842	4729
query73	748	647	348	348
query74	8902	9179	8776	8776
query75	4364	3190	2701	2701
query76	4420	1182	757	757
query77	988	379	279	279
query78	10034	10167	9254	9254
query79	2396	806	562	562
query80	609	525	435	435
query81	488	251	218	218
query82	464	129	96	96
query83	290	259	243	243
query84	300	114	85	85
query85	814	374	314	314
query86	384	291	290	290
query87	4482	4419	4344	4344
query88	3524	2194	2203	2194
query89	387	309	271	271
query90	1821	207	213	207
query91	149	151	117	117
query92	77	62	56	56
query93	1790	940	569	569
query94	665	428	302	302
query95	384	293	285	285
query96	475	563	275	275
query97	3142	3243	3155	3155
query98	221	206	210	206
query99	1439	1447	1237	1237
Total cold run time: 277377 ms
Total hot run time: 185782 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f45537674436f40f19e1a5bc289bf655963903c9, data reload: false

query1	0.04	0.04	0.04
query2	0.13	0.11	0.10
query3	0.25	0.20	0.20
query4	1.59	0.21	0.11
query5	0.57	0.55	0.55
query6	1.18	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.53	0.51
query10	0.63	0.59	0.57
query11	0.16	0.10	0.10
query12	0.16	0.12	0.11
query13	0.62	0.59	0.61
query14	2.66	2.84	2.71
query15	0.92	0.85	0.84
query16	0.40	0.40	0.39
query17	1.02	1.03	1.02
query18	0.21	0.20	0.19
query19	1.97	1.87	1.82
query20	0.01	0.02	0.01
query21	15.38	0.88	0.56
query22	0.76	1.23	0.98
query23	14.73	1.38	0.57
query24	7.81	0.84	0.82
query25	0.48	0.10	0.07
query26	0.66	0.16	0.13
query27	0.05	0.05	0.06
query28	9.43	0.89	0.44
query29	12.54	4.01	3.37
query30	0.26	0.09	0.06
query31	2.81	0.58	0.39
query32	3.22	0.54	0.46
query33	3.07	3.07	3.09
query34	15.70	5.05	4.47
query35	4.50	4.53	4.49
query36	0.65	0.50	0.48
query37	0.08	0.07	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.68 s
Total hot run time: 31.35 s

@starocean999 starocean999 marked this pull request as ready for review April 14, 2025 01:58
morrySnow
morrySnow reviewed Apr 15, 2025
View reviewed changes
...-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateFunctionCommand.java
@@ -889,6 +891,7 @@ private TFunctionBinaryType getFunctionBinaryType(String type) {
private void analyzeAliasFunction(ConnectContext ctx) throws AnalysisException {
function = AliasFunction.createFunction(functionName, argsDef.getArgTypes(),
Type.VARCHAR, argsDef.isVariadic(), parameters, translateToLegacyExpr(originFunction, ctx));
((AliasFunction) function).analyze();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd better not rely ont catalog's function's analyze methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@starocean999 @hello-stephen @doris-robot @morrySnow