Skip to content

[fix](cloud-mow) Make new MS can erase initiator when upgrading MS #49716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 14, 2025
Merged

[fix](cloud-mow) Make new MS can erase initiator when upgrading MS #49716

merged 6 commits into from
Apr 14, 2025

Conversation

hust-hhb
Copy link
Contributor

@hust-hhb hust-hhb commented Mar 31, 2025 •
edited
Loading

Here is a scene

  1. Upgrading MS, now we have a new MS and an old MS
  2. Compaction applied for delete bitmap lock in the old MS
  3. Compaction failed to update delete bitmap in new ms because of tablet compaction key not found
  4. Compaction abort
  5. Compaction failed to perform an abort in the new MS because of tablet compaction key not found, witch will lead to fail to release delete bitmap lock
    Now this pr can make step 5 success, so delete bitmap lock can release successfully during upgrade ms

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

run buildall

@hust-hhb hust-hhb changed the title [fix](cloud-mow) Should clear initiators when upgrading MS [fix](cloud-mow) Should erase initiator when upgrading MS Apr 10, 2025
@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1089/1312)
Line Coverage: 66.07% (18165/27494)
Region Coverage: 65.52% (8951/13661)
Branch Coverage: 55.36% (4822/8710)
Coverage Report: http://coverage.selectdb-in.cc/coverage/edcc613ff7ea6702f7900ef6a0513d5ae0b11447_edcc613ff7ea6702f7900ef6a0513d5ae0b11447_cloud/report/index.html

@hust-hhb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1089/1312)
Line Coverage: 66.09% (18172/27496)
Region Coverage: 65.54% (8953/13661)
Branch Coverage: 55.40% (4825/8710)
Coverage Report: http://coverage.selectdb-in.cc/coverage/300c46c0b77520d3a699ef185dee7ba1a75872d7_300c46c0b77520d3a699ef185dee7ba1a75872d7_cloud/report/index.html

zhannngchen
zhannngchen approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hust-hhb hust-hhb changed the title [fix](cloud-mow) Should erase initiator when upgrading MS [fix](cloud-mow) Make new MS can erase initiator when upgrading MS Apr 11, 2025
dataroaring
dataroaring approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 40f085e into apache:master Apr 14, 2025
28 of 29 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
@hust-hhb @seawinde
[fix](cloud-mow) Make new MS can erase initiator when upgrading MS (a…
1bff53e 
…pache#49716)

Here is a scene
1. Upgrading MS, now we have a new MS and an old MS
2. Compaction applied for delete bitmap lock in the old MS
3. Compaction failed to update delete bitmap in new ms because of tablet
compaction key not found
4. Compaction abort
5. Compaction failed to perform an abort in the new MS because of tablet
compaction key not found, witch will lead to fail to release delete
bitmap lock
Now this pr can make step 5 success, so delete bitmap lock can release
successfully during upgrade ms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mymeiyi mymeiyi mymeiyi approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hust-hhb @hello-stephen @doris-robot @mymeiyi @zhannngchen @dataroaring