DRILL-8543: Add Support for Materialized Views#3036
Open
cgivre wants to merge 9 commits intoapache:masterfrom
Open
DRILL-8543: Add Support for Materialized Views#3036cgivre wants to merge 9 commits intoapache:masterfrom
cgivre wants to merge 9 commits intoapache:masterfrom
Conversation
cgivre
added
enhancement
letian-jiang
reviewed
Feb 6, 2026
Contributor
letian-jiang
left a comment
letian-jiang
left a comment
There was a problem hiding this comment.
LGTM. Materialized view is a powerful feature for analytic engine. 🥳
...a-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/MaterializedViewHandler.java
Show resolved
Hide resolved
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
Show resolved
Hide resolved
letian-jiang
approved these changes
Feb 6, 2026
Contributor
letian-jiang
left a comment
letian-jiang
left a comment
There was a problem hiding this comment.
We could also add a plan-asserting test to ensure the query is correctly rewrite using MV.
Contributor
Author
|
@letian-jiang I believe I addressed your review comments. Could you please mark the review as complete so we can merge? |
The MV rewriter had three bugs preventing query rewriting from working: 1. Schema discovery used lazy-loaded schema tree (always empty) - now iterates StoragePluginRegistry for FileSystemPlugin instances 2. SubstitutionVisitor arguments were swapped - now uses Calcite's RelOptMaterializations.useMaterializedViews() API which handles normalization and correct argument order internally 3. buildMvScanRel used SELECT * causing DYNAMIC_STAR type mismatch - now selects explicit columns from the MV field definitions Also adds plan verification tests to both TestMaterializedViewSupport and TestMaterializedViewRewriting to assert that query plans actually reference _mv_data (Parquet) or region.json as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRILL-8543: Add Support for Materialized Views
Description
This PR adds materialized view support to Apache Drill, enabling users to store pre-computed query results for improved query performance.
Features
Implementation
Configuration
planner.enable_materialized_view_rewrite(default: true) - Controls automatic query rewritingDocumentation
Added docs/dev/MaterializedViews.md with complete feature documentation
Testing
Added additional unit tests.