Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split unit test #14645

Draft
wants to merge 3 commits into
base: 3.3
Choose a base branch
from
Draft

Split unit test #14645

wants to merge 3 commits into from

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Sep 6, 2024

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@oxsean oxsean force-pushed the split-unit-test branch 16 times, most recently from 4dd50a4 to d3dc714 Compare September 7, 2024 10:49
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.14%. Comparing base (392baa3) to head (ffc1059).
Report is 59 commits behind head on 3.3.

Current head ffc1059 differs from pull request most recent head 4569f29

Please upload reports for the commit 4569f29 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##              3.3   #14645       +/-   ##
===========================================
- Coverage   38.05%    7.14%   -30.92%     
===========================================
  Files        1804     7920     +6116     
  Lines       80043   425040   +344997     
  Branches    11898    66678    +54780     
===========================================
- Hits        30461    30361      -100     
- Misses      45190   390293   +345103     
+ Partials     4392     4386        -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxsean oxsean force-pushed the split-unit-test branch 13 times, most recently from c96ae5b to 8e61db8 Compare September 8, 2024 12:26
@oxsean oxsean force-pushed the split-unit-test branch 2 times, most recently from ffc1059 to 4569f29 Compare September 8, 2024 13:01
@oxsean oxsean marked this pull request as draft September 9, 2024 15:56
@oxsean oxsean force-pushed the split-unit-test branch 2 times, most recently from b094467 to cbd4a1e Compare September 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants