Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Time Axis Label Handling for ECharts --- Fix #19737 #19862

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

WZY009
Copy link

@WZY009 WZY009 commented Apr 24, 2024

This test case addresses the issue where the time axis in ECharts incorrectly generates labels for series with no data, resulting in misleading visual indications on the graph. The should generate correct labels for time axis with non-empty data series test ensures that labels are correctly generated for time axes with valid data points, verifying that the date range is accurately represented. Conversely, the should not generate labels for empty data series on a time axis test confirms that no labels are produced when the data series is empty, preserving the integrity of the axis range. This improvement is essential for maintaining accurate data representation, particularly in dynamic charts where data streams might intermittently have empty series.

Copy link

echarts-bot bot commented Apr 24, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit the changes in dist, and *.json, along with unnecessary changes like spaces. You may need to disable tools like prettier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants