-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): marker upgrade for stock charts #20166
base: v6
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request is marked to be |
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20166@29c83aa |
Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
Brief Information
This pull request is in the type of:
What does this PR do?
Enhance the ability of markerPoint so that we can do more for stock charts.
Fixed issues
#19578
Details
Before: What was the problem?
We can only set the position of markPoints according to the whole canvas, but not to the grid area in pixels.
After: How does it behave after the fixing?
With
relativeTo: 'coordinate'
, we can set the position in pixels according to the grid area.Document Info
New API:
markPoint.data.relativeTo: 'screen' | 'coordinate'
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information