Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): Removal of partial connections around null values for step lines with connectNulls=false #20258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daless14
Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Resolves #20191

Details

Before: What was the problem?

For step line charts, connections were partially drawn between null values and other data points with "connectNulls" set to false.

image

After: How does it behave after the fixing?

Gaps are shown correctly for null values with no partial lines drawn.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Aug 15, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@daless14
Copy link
Author

daless14 commented Nov 4, 2024

Just wanting to check back on this PR. Is there something that should be changed/improved before it can get pulled in? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Step graph and "connectNulls = false" connects where it should not
1 participant