Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataZoom refresh #20458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DataZoom refresh #20458

wants to merge 1 commit into from

Conversation

Jackerking
Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixes the DataZoom component view refresh issue that caused only part of the plot to render correctly.

Fixed issues

Details

Before: What was the problem?

In the previous implementation, the DataZoom component failed to refresh the entire plot area after zoom interactions, causing only parts of the plot to render, while the rest remained unrefreshed or partially visible.

Screenshot Before Fix (Optional)

image

After: How does it behave after the fixing?

After applying this fix, the DataZoom component now fully refreshes the plot area, rendering the entire visual correctly after user interactions like zooming or panning. This was achieved by adding a dispatchAction call in the render method, forcing the view to reset and display the specified data range from 0 to 100%.

Screenshot After Fix

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

N.A.

Signed-off-by: jzq <[email protected]>
Copy link

echarts-bot bot commented Oct 29, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be the correct place to fix this problem. Usually actions should not be dispatched in render because it's not the rendering action caused the dataZoom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants