feat(label): enforce labelLayout for all state #20476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: awaiting review
PR: doc unchanged
PR: first-time contributor
labels
|
Thanks for your contribution! |
Before
After
|
Future worksSupport |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20476@931326a |
A0nameless0man
force-pushed
the
fix/label
branch
from
2da948a
to
a1290b2
Compare
A0nameless0man
force-pushed
the
fix/label
branch
from
a1290b2
to
6bda901
Compare
Unit testThere is only one test Initial state is same. And test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Make sure
labelLayoutis enforced to all four state of label.Fixed issues
labelLayoutoption ignored in blur state for sunburst chart.Example
Details
Before: What was the problem?
Current impl of sunburst chart calculates label position in SunburstPiece.ts, and apply it to all display state. However, this impl didn't take
labelLayoutinto account and causes conflict aslabelLayoutis only applied to normal state for now.This inconsistency causes strange animation on mouse hover.
After: How does it behave after the fixing?
Now with this pr,
labelLayoutalways takes priority.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information
As an inexperienced front-end developer, this PR may require more reviews to avoid breaking any existing use cases. Also, I am currently unable to add unit tests for this PR, which may require further processing.