Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radar): Radar series tooltip support dimensionIndex #20677

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(radar): Radar series tooltip support dimensionIndex #20677

wants to merge 2 commits into from

Conversation

AielloChan
Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Just add dimensionIndex into radar chart series tooltip's callback param.

Fixed issues

#10537

Details

Before: What was the problem?

I just wanna get which axis my cursor is point on. In this example, I wanna get "小明"

image

After: How does it behave after the fixing?

In radar chart, when cursor point at series symbol area, tooltip callback's params will contain dimensionIndex , which indicate which axis you just pointed.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot ECharts Bot
Copy link

echarts-bot bot commented Jan 10, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Ovilia
Ovilia requested changes Jan 13, 2025
View reviewed changes
@Ovilia
Copy link
Contributor

Ovilia commented Jan 13, 2025

Please don't use forced pushes because it makes it hard to trace the data changes.

@AielloChan
Copy link
Author

Please don't use forced pushes because it makes it hard to trace the data changes.

Oh, I just force write my init uncompleted commit, will not force push further.

@AielloChan
Copy link
Author

@Ovilia Hello, please review my code, thx

@AielloChan AielloChan requested a review from Ovilia January 20, 2025 01:43
@github-actions GitHub Actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20677@460fe5e

@AielloChan
Copy link
Author

Any progress on this PR?

@AielloChan
Copy link
Author

@plainheart @100pah Does anyone can review my PR? Thanks a lot 🙏

@AielloChan
Copy link
Author

One month later, anyone can help?

AielloChan

This comment was marked as resolved.

Sign in to view

@AielloChan
Copy link
Author

Did I miss something?

@AielloChan
Copy link
Author

Does the code need any changes?

@Ovilia
Copy link
Contributor

Ovilia commented Mar 10, 2025

Thanks for the contribution and sorry for the late reply. I'll review it now. 😄

Ovilia
Ovilia requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a overwriting getDataParams in RadarSeries as FunnelSeries does now.

src/model/mixin/dataFormat.ts
@@ -88,6 +90,7 @@ export class DataFormatMixin {
color: color,
borderColor: borderColor,
dimensionNames: userOutput ? userOutput.fullDimensions : null,
dimensionIndex: el ? el.__dimIdx : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimensionIndex is only for radar series, so it should not be included here.

src/util/types.ts
/**
* From RadarSymbol
*/
__dimIdx?: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__dimIdx is only for radar series, so it should not be included here.

@Ovilia
Copy link
Contributor

Ovilia commented Mar 10, 2025

I think this should be a great feature to introduce in ECharts 6.0. Please let me know if you need further help on this. I will check this PR regularly in case I miss anything more. Thanks!

@Ovilia
Copy link
Contributor

Ovilia commented Mar 10, 2025

Should this be called indicatorIndex instead of dimensionIndex?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
PR: doc unchanged PR: first-time contributor PR: revision needed size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AielloChan @Ovilia