Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(tooltip): added container prop for tooltip placement #20815

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

malmakova-na
Copy link

@malmakova-na malmakova-na commented Mar 10, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

rekilina and others added 21 commits February 26, 2024 13:57
fix(LegendView): fix layout width and position
…593950 (#6)

* fix(pie) fixed half pie slices propotions on legend item toggle

* refactor(pie) lint-fixes

* fix(labelLine): fix emphasis.labelLine is not working in pie chart (manual upgrade)

* feat(pie): add endAngle for control pie range (manual upgrade)

* feat(pie): add padAngle option (manual upgrade)

* fix(pie): fix endAngle is not applied on the empty circle (manual upgrade)

* refactor(pie) obsolent code

* feat(pie) build

* Revert "feat(pie) build"

This reverts commit 16b890f.

* refactor(pie) remove code of the  deprecated solution

* feat(pie) build v2
* feat(pie) add optional title to pie chart

* feat(pie) pie title build

* fix(pie) title positioning

* fix(pie) lint

* feat(pie) formatter prop for title

* feat(pie) title graphics reset
* feat(xAxis): ticks interval is counted without binding to change of higher level unit

* lint-fix

* feat(xAxis): apply custom interval when it's passed to chart options

* feat(xAxis): _isIntervalCustom fix

* feat(xAxis): add custom interval for all time units

* release files

* feat(xAxis): refactor

* release files

---------

Co-authored-by: rekilina <[email protected]>
* fixed number of minor ticks depending on interval

* release

* lint fix

* time logic moved to class Time

* refactored getMinorSplits

* fixed minor ticks close to main ticks

* release

* fix ticks in getIntervalTicks

* release

* fixed month splits and different units checking

* release
Copy link

echarts-bot bot commented Mar 10, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please sync the project before making a PR. There seems to be a lot of unrelated commits here. I'd suggest closing this one and recreate a PR. Make sure you describe clearly in the PR description.

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a new option appendTo to set the tooltip container since v5.5.0. The original PR is at #18436.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants