Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 #4818

Closed
wants to merge 4 commits into from

Conversation

VishalMCF
Copy link
Contributor

@VishalMCF VishalMCF commented Apr 8, 2024

Fixes #4540

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 8, 2024

Kindly refer to the standard title format used in other PRs.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 8, 2024

plz check ci~

@Pil0tXia Pil0tXia changed the title added test cases for threadUtils class [ISSUE #4540] Add test cases for ThreadUtils class Apr 14, 2024
@Pil0tXia
Copy link
Member

@VishalMCF Please check CI failure.

@VishalMCF VishalMCF changed the title [ISSUE #4540] Add test cases for ThreadUtils class [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 Apr 14, 2024
@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 14, 2024

@VishalMCF Please be informed that the CI still failed. You may refer to https://eventmesh.apache.org/community/contribute/contribute for help.

@VishalMCF
Copy link
Contributor Author

VishalMCF commented Apr 14, 2024

@Pil0tXia I ran the checkstyle plugin. But the file which i worked on is now fixed as per the results. But there is another file
我运行了 checkstyle 插件。但我处理的文件现在已根据结果修复。但还有另一个文件——

-> Execution failed for task ':eventmesh-protocol-plugin:eventmesh-protocol-grpc:generateProto'.

protoc: stdout: . stderr: /Users/vishalyadav/.gradle/caches/modules-2/files-2.1/io.grpc/protoc-gen-grpc-java/1.43.2/d1f6199ad60848a873bd14fc8deefc6733b75586/protoc-gen-grpc-java-1.43.2-osx-aarch_64.exe: program not found or is not executable
Please specify a program using absolute path or make sure the program is available in your PATH system variable
--grpc_out: protoc-gen-grpc: Plugin failed with status code 1.

This is failing.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 15, 2024

@VishalMCF

I re-ran the failed task of CI and it is still failing.

image

May you please check debug log for detailed information?


The log you reported about ':eventmesh-protocol-plugin:eventmesh-protocol-grpc:generateProto' seems to be a local dependency installation problem.

@VishalMCF
Copy link
Contributor Author

@Pil0tXia I checked it is failing because of the randomized test case. Its failing during build. ALthough on my local machine it passes.

@VishalMCF VishalMCF closed this Apr 15, 2024
@VishalMCF VishalMCF deleted the test/Threadutils branch April 15, 2024 12:39
@Pil0tXia
Copy link
Member

failing because of the randomized test case

You can absolutely make changes to other test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Unit Test] Unit test for ThreadUtils
2 participants