Skip to content

FINERACT-2560: Fix NullPointerException in calcInterestTransactionWaivedAmount#5714

Merged
adamsaghy merged 1 commit intoapache:developfrom
San-43:FINERACT-2560-Fix-NullPointerException-in-calcInterestTransactionWaivedAmount
Apr 6, 2026
Merged

FINERACT-2560: Fix NullPointerException in calcInterestTransactionWaivedAmount#5714
adamsaghy merged 1 commit intoapache:developfrom
San-43:FINERACT-2560-Fix-NullPointerException-in-calcInterestTransactionWaivedAmount

Conversation

@San-43
Copy link
Copy Markdown
Contributor

@San-43 San-43 commented Mar 30, 2026

This PR fixes FINERACT-2560 and adds a test to verify the fix.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@San-43 San-43 force-pushed the FINERACT-2560-Fix-NullPointerException-in-calcInterestTransactionWaivedAmount branch from 19edc7c to b60023c Compare April 1, 2026 18:15
…vedAmount by adding null check for LoanTransaction
@San-43 San-43 force-pushed the FINERACT-2560-Fix-NullPointerException-in-calcInterestTransactionWaivedAmount branch from b60023c to bdba01f Compare April 1, 2026 18:26
Copy link
Copy Markdown
Contributor

@DeathGun44 DeathGun44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit b688899 into apache:develop Apr 6, 2026
47 of 48 checks passed
@San-43 San-43 deleted the FINERACT-2560-Fix-NullPointerException-in-calcInterestTransactionWaivedAmount branch April 7, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants