Skip to content

FINERACT-2421: the loan originator information missing events#5738

Open
budaidev wants to merge 1 commit intoapache:developfrom
openMF:FINERACT-2421/fix-originator-missing-in-events
Open

FINERACT-2421: the loan originator information missing events#5738
budaidev wants to merge 1 commit intoapache:developfrom
openMF:FINERACT-2421/fix-originator-missing-in-events

Conversation

@budaidev
Copy link
Copy Markdown
Contributor

@budaidev budaidev commented Apr 3, 2026

the loan originator information is missing in LoanAdjustTransactionBusinessEvent and LoanAccrualTransactionCreatedBusinessEvent

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy
Copy link
Copy Markdown
Contributor

Execution failed for task ':integration-tests:spotlessJavaCheck'.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
> The following files had format violations:
      src/test/java/org/apache/fineract/integrationtests/client/feign/tests/FeignLoanAdjustmentOriginatorEnricherTest.java
          @@ -125,10 +125,8 @@
           
           ············//·Add·a·fee·charge·to·the·loan
           ············final·Long·chargeId·=·createFlatFeeCharge(100.0,·"EUR");
          -············ok(()·->·fineractClient.loanCharges().executeLoanCharge(loanId,
          -····················new·PostLoansLoanIdChargesRequest().chargeId(chargeId).amount(100.0).locale("en").dateFormat("dd·MMMM·yyyy")
          -····························.dueDate(today),
          -····················(String)·null));
          +············ok(()·->·fineractClient.loanCharges().executeLoanCharge(loanId,·new·PostLoansLoanIdChargesRequest().chargeId(chargeId)
          +····················.amount(100.0).locale("en").dateFormat("dd·MMMM·yyyy").dueDate(today),·(String)·null));
           
           ············externalEventHelper.deleteAllExternalEvents();
           
          @@ -162,10 +160,9 @@
           
           ············//·Add·a·fee·charge·and·waive·it
           ············final·Long·chargeId·=·createFlatFeeCharge(100.0,·"EUR");
          -············final·Long·loanChargeId·=·ok(()·->·fineractClient.loanCharges().executeLoanCharge(loanId,
          -····················new·PostLoansLoanIdChargesRequest().chargeId(chargeId).amount(100.0).locale("en").dateFormat("dd·MMMM·yyyy")
          -····························.dueDate(today),
          -····················(String)·null)).getResourceId();
          +············final·Long·loanChargeId·=·ok(()·->·fineractClient.loanCharges().executeLoanCharge(loanId,·new·PostLoansLoanIdChargesRequest()
          +····················.chargeId(chargeId).amount(100.0).locale("en").dateFormat("dd·MMMM·yyyy").dueDate(today),·(String)·null))
          +····················.getResourceId();
           
           ············ok(()·->·fineractClient.loanCharges().executeLoanChargeOnExistingCharge(loanId,·loanChargeId,
           ····················new·PostLoansLoanIdChargesChargeIdRequest(),·"waive"));
  Run './gradlew :integration-tests:spotlessApply' to fix these violations.

@budaidev budaidev force-pushed the FINERACT-2421/fix-originator-missing-in-events branch from e736127 to fba5ef8 Compare April 3, 2026 16:31
…stTransactionBusinessEvent and LoanAccrualTransactionCreatedBusinessEvent
@budaidev budaidev force-pushed the FINERACT-2421/fix-originator-missing-in-events branch from fba5ef8 to f8fab37 Compare April 3, 2026 16:50
@budaidev budaidev marked this pull request as ready for review April 3, 2026 20:59
Copy link
Copy Markdown
Contributor

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Major Changes are the addition of test cases and Main changes are done in
fineract-loan-origination/src/main/java/org/apache/fineract/portfolio/loanorigination/enricher/LoanTransactionAdjustmentDataV1OriginatorEnricher.java

and

fineract-loan-origination/src/main/java/org/apache/fineract/portfolio/loanorigination/helper/LoanOriginatorDetailsResolver.java

and then propagated to everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants