[FLINK-35067][cdc-connector][postgres] Adding metadata 'row_kind' for Postgres CDC Connector. #3716
Conversation
… Postgres CDC Connector.
|
Hi @oli2v, This feature is meaningful to me, but it seems that there are many irrelevant changes in the code (including test code), was this adjusted by IDE？We should try to minimize irrelevant changes as much as possible. |
…ind' for Postgres CDC Connector." This reverts commit 028313a.
|
Hi @lvyanquan, those irrelevant changes in the code were indeed due to the IDE. I just pushed a new commit trying to minimize them. |
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
|
|
There was a problem hiding this comment.
Thanks for the update and it looks better, but I'm wondering this change of import orders is necessary?
There was a problem hiding this comment.
Thanks for the update and it looks better, but I'm wondering this change of import orders is necessary?
You can use mvn spotless:apply to correct the import orders.
|
LGTM. And a doc update in postgres available-metadata will be more appreciated. You can find the doc in https://github.com/apache/flink-cdc/blob/master/docs/content/docs/connectors/flink-sources/postgres-cdc.md |
No description provided.