[FLINK-36971][Connectors/Sqs] Add Sqs SQL connector #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahmed-hamdy
force-pushed
the
sqs-sql-sink
branch
from
009002c to
d5178f0
Compare
vahmed-hamdy
changed the title
|
@hlteoh37 could you please help review this PR? |
darenwkt
reviewed
Apr 23, 2025
| jar, | ||
| Arrays.asList( | ||
| "org/apache/flink/", | ||
| "org/apache/commons/", |
There was a problem hiding this comment.
Should we shade and relocate this to org.apache.flink.connector.sqs.shaded like the other dependencies?
darenwkt
reviewed
Apr 30, 2025
| <include>org.apache.flink:flink-connector-sqs</include> | ||
| <include>software.amazon.awssdk:*</include> | ||
| <include>org.reactivestreams:*</include> | ||
| <include>com.typesafe.netty:*</include> |
There was a problem hiding this comment.
Could we double check if com.typesafe.netty:* is actually bundled and relocated in the jar please? I did a quick check and couldn't find it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Add SQS SQL connector wrapper for table api connector
Verifying this change
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))