[FLINK-29549]- Flink Glue Catalog integration #206
Conversation
Co-Authored-By: Anthony Pounds-Cornish <[email protected]>
refactoring directory Adding Parent Pom
FranMorilloAWS
changed the title
FranMorilloAWS
changed the title
There was a problem hiding this comment.
Thanks for the contribution. A few points to note:
It looks like most of the code has already been reviewed across multiple PRs.
Concerns:
-
The current implementation exposes low-level Glue details (e.g., support for lowercase table names) directly through the Flink Catalog. Is this acceptable? I recommend raising this topic with the community. In my opinion, it would be better to encapsulate such Glue-specific behavior and avoid exposing it directly via the Flink Catalog interface. The catalog's behavior should remain consistent with other catalogs, with differences controlled via configuration only.
-
Please consider implementing the basic configuration options defined in FLIP-277. If that’s not feasible in this PR, a fast follow-up would be valuable, especially for users relying on different credential modes.
-
It seems that some
.ideafolder files have been committed. Please remove them from the PR.
Cheers,
Samrat
| @@ -0,0 +1,2 @@ | |||
| ./target | |||
There was a problem hiding this comment.
is this gitignore file required
| @@ -0,0 +1,10 @@ | |||
| # Default ignored files | |||
| @@ -0,0 +1,18 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,15 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
why do you need this file ?
Purpose of the change
For example: Implements the Table API for the Kinesis Source.
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))