[hotfix] Adapt supported Python versions to Flink 1.20 #223
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
gguptp
suggested changes
Dec 15, 2025
| README_FILE = os.path.join(CURRENT_DIR, 'README.txt') | ||
|
|
||
| # Generated files and directories | ||
| VERSION_FILE = os.path.join(CURRENT_DIR, 'pyflink/datastream/connectors/aws_connector_version.py') |
Contributor
There was a problem hiding this comment.
could the failure be due to we using different connector version whereas this file doesnt exist. Shoudl we rather use pyflink/datastream/connectors/kinesis.py as is there in main branch?
Comment on lines
106
to
107
| "../flink-connector-aws/flink-connector-kinesis/src/main" + | ||
| "/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java") |
Contributor
There was a problem hiding this comment.
same here, should we rather use:
in_flink_source = os.path.isfile(
"../flink-connector-aws/flink-connector-aws-kinesis-streams/src/main" +
"/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java")
as is there in the main branch?
ferenc-csaky
force-pushed
the
fix-python-build
branch
from
f0f96ff to
5ce1337
Compare
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.