[FLINK-35404] Report all metrics of KafkaConsumer in new Kafka source #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink docs state that all
KafkaConsumer
related metrics are reported by Flink under MetricGroupKafkaSourceReader.KafkaConsumer
per flink docs.However, only metrics registered with KafkaConsumer at creation are registered under aforementioned Flink MetricGroup.
This causes important metrics like consumer-lag to be missing. Flink does publish
consumer-lag
metric but loses fidelity like topic and partition info available as tags.The PR fixes this issue by providing a Flink
MetricGroup
implementation for KafkaMetricsReporter
interface. This ensures that metrics registered at any point in kafka consumer lifecycle will be correctly added to Flink MetricRegistry.