Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32743][Connectors/Kafka] Parse data from kafka connect and convert it into regular JSON data #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sunxiaojian
Copy link

Add "record.key.include.kafka.connect.json.schema" and "record.value.include.kafka.connect.json.schema" configurations. When this configuration is true, records can be converted into regular JSON data

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 4, 2023

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@sunxiaojian sunxiaojian force-pushed the support-kafka-connect-record branch 2 times, most recently from de74496 to 6d3dbe7 Compare August 4, 2023 10:45
@MartijnVisser
Copy link
Contributor

@sunxiaojian Can you please rebase your PR?

@sunxiaojian
Copy link
Author

@sunxiaojian Can you please rebase your PR?

@MartijnVisser Thanks for your review, it has been processed

@MartijnVisser
Copy link
Contributor

Thanks for your review, it has been processed

CI is failing, will you take a look?

@sunxiaojian sunxiaojian force-pushed the support-kafka-connect-record branch 7 times, most recently from 966a84d to cbf7725 Compare January 26, 2024 06:15
@sunxiaojian
Copy link
Author

Thanks for your review, it has been processed

CI is failing, will you take a look?

@MartijnVisser fixed

@MartijnVisser
Copy link
Contributor

@mas-chen Want to take a look?

@mas-chen
Copy link
Contributor

mas-chen commented Feb 16, 2024

@sunxiaojian have you considered implementing this as a Flink format? You could draw inspiration from pre-existing formats: https://github.com/apache/flink/tree/master/flink-formats/flink-json/src/main/java/org/apache/flink/formats/json

For example, the debezium json format already has an integration with Kafka connect.

@sunxiaojian
Copy link
Author

@sunxiaojian have you considered implementing this as a Flink format? You could draw inspiration from pre-existing formats: https://github.com/apache/flink/tree/master/flink-formats/flink-json/src/main/java/org/apache/flink/formats/json

For example, the debezium json format already has an integration with Kafka connect.

@mas-chen ok, that's a good suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants