[FLINK-34127] Upgrade to flink-connector-parent 1.1.0 to exclude runn… #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shaves 1-2 minutes from CI |
mas-chen
force-pushed
the
FLINK-34127-new
branch
2 times, most recently
from
2566dab
to
e11942e
Compare
…ing nested unit tests
mas-chen
force-pushed
the
FLINK-34127-new
branch
from
e11942e
to
2f61126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing nested unit tests
The root cause of the duplicate nested test execution is noted in this github issue: junit-team/junit5#3782. TLDR, the outer test runs once (running all its nested tests), then the nested tests run again due to the include test regex.
Surefire also excludes nested tests by default. https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html
I have tested this approach in mas-chen#8 and realized that excluding tests was only available from 1.1.0 of the parent pom.