Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36675][table-planner] Always serialize dynamic options to exec json plan #25626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xuyangzhong
Copy link
Contributor

What is the purpose of the change

Before this fix, dynamic option hints will not take effect when restoring exec plan from json plan without setting 'table.plan.compile.catalog-objects' to 'all'.

This fix is trying to always serialize dynamic options to exec json plan, and merge them to table options when restoring from json plan.

Brief change log

  • Add a field for dynamic options in DynamicTableSpecBase to let it can be serialized to json plan
  • Add UT and IT cases

Verifying this change

Some tests are added to verify this fix.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 8, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants