Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35966][runtime] Introduce the TASKS for TaskManagerLoadBalanceMode enum #25647

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RocMarshal
Copy link
Contributor

What is the purpose of the change

  • [FLINK-35966][runtime] Introduce the TASKS for TaskManagerLoadBalanceMode enum
  • [FLINK-36691][runtime] Support configuration to enable tasks balancing at slot level for Default Scheduler

Brief change log

  • [FLINK-35966][runtime] Introduce the TASKS for TaskManagerLoadBalanceMode enum
  • [FLINK-36691][runtime] Support configuration to enable tasks balancing at slot level for Default Scheduler

Verifying this change

This change is already covered by existing tests,

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@RocMarshal RocMarshal marked this pull request as ready for review November 12, 2024 14:40
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 12, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@RocMarshal
Copy link
Contributor Author

hi, @zhuzhurk @1996fanrui Could you help take a look for the PR if you had the free time ?
Many thanks !

Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, task balancing needs 2 level:

  • Task to Slot
  • Slot to TM

This PR will Introduce the TASKS for TaskManagerLoadBalanceMode enum, and only support task balancing at slot level. And Slot to TM will be supported later.

I think it's acceptable for Flink 2.0, and I hope hear the suggestion from @zhuzhurk .

@zhuzhurk
Copy link
Contributor

As I understand, task balancing needs 2 level:

  • Task to Slot
  • Slot to TM

This PR will Introduce the TASKS for TaskManagerLoadBalanceMode enum, and only support task balancing at slot level. And Slot to TM will be supported later.

I think it's acceptable for Flink 2.0, and I hope hear the suggestion from @zhuzhurk .

Does you mean that the balance of Slot to TM[1] is not planned to be supported in Flink 2.0?

[1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-370%3A+Support+Balanced+Tasks+Scheduling#FLIP370:SupportBalancedTasksScheduling-3.2.3ImplementslotstoTMsbalancingforDefaultScheduler:

@RocMarshal
Copy link
Contributor Author

Thanks @zhuzhurk @1996fanrui for the comments.

Please let me to synchronize the background information and introduce the reasons for this change.

The feature freeze for version 2.0 will take place at the end of November 2024.

Does you mean that the balance of Slot to TM[1] is not planned to be supported in Flink 2.0?

We expect to release this complete feature in 2.0 ideally
but I estimate that the two core PRs at the TaskManager level may face some risks based on the current progress,

Meanwhile, for FLIP-370,

Therefore, I'd like to attempt to first support the slot-level balancing for the two schedulers.

Please let me know what's your opinion~ Thx!

@zhuzhurk
Copy link
Contributor

zhuzhurk commented Nov 15, 2024

Thanks @zhuzhurk @1996fanrui for the comments.

Please let me to synchronize the background information and introduce the reasons for this change.

The feature freeze for version 2.0 will take place at the end of November 2024.

Does you mean that the balance of Slot to TM[1] is not planned to be supported in Flink 2.0?

We expect to release this complete feature in 2.0 ideally but I estimate that the two core PRs at the TaskManager level may face some risks based on the current progress,

Meanwhile, for FLIP-370,

Therefore, I'd like to attempt to first support the slot-level balancing for the two schedulers.

Please let me know what's your opinion~ Thx!

The feature freeze for version 2.0 will take place at the end of November 2024

The feature freeze date has been postponed to 2025-01-13[1]. Will it give enough time to complete the FLIP?

[1] "[DISCUSS] Feature Freeze for Flink 2.0 - Jan 13" in dev ML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants