Skip to content

Conversation

@liuyongvs
Copy link
Contributor

What is the purpose of the change

The PR migrates PruneAggregateCallRule to java

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

.boxed()
.sorted(Comparator.reverseOrder())
.forEach(index -> newAggCalls.remove((int) index));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments: newAggCalls.remove((int) index) , we need this int cast here. because it will remove the value instead of removing index when doesn't have int cast

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like better to have this as a comment in source

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added @snuyanzin

@liuyongvs
Copy link
Contributor Author

i don't have permission for reopen pr for this #25900
so i open a new pr, @snuyanzin will you have a look?

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 4, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@github-actions github-actions bot added the community-reviewed PR has been reviewed by the community. label Jan 4, 2026
@liuyongvs liuyongvs requested a review from snuyanzin January 5, 2026 05:17
@liuyongvs
Copy link
Contributor Author

@snuyanzin will you help review this?

@snuyanzin snuyanzin merged commit 83ce278 into apache:master Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants