Skip to content

Deprecate Spring JSP theme support for removal in Grails 8.0.0 #15457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesfredley merged 1 commit into from
Feb 26, 2026
+17 −0
Merged

Deprecate Spring JSP theme support for removal in Grails 8.0.0 #15457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions grails-spring/src/main/groovy/org/grails/spring/GrailsApplicationContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,25 @@ public void setMetaClass(MetaClass metaClass) {

/**
* Initialize the theme capability.
*
* @deprecated since 7.1, for removal in 8.0. Spring's theme support ({@link ThemeSource},
* {@link UiApplicationContextUtils#initThemeSource}) is deprecated in Spring Boot 3 and
* removed in Spring Boot 4. This method will be removed in Grails 8.0.0.
*/
@Deprecated(since = "7.1", forRemoval = true)
@Override
protected void onRefresh() {
themeSource = UiApplicationContextUtils.initThemeSource(this);
}

/**
* Return the {@link Theme} instance for the given theme name.
*
* @deprecated since 7.1, for removal in 8.0. Spring's theme support ({@link ThemeSource},
* {@link Theme}) is deprecated in Spring Boot 3 and removed in Spring Boot 4.
* This method will be removed in Grails 8.0.0.
*/
@Deprecated(since = "7.1", forRemoval = true)
public Theme getTheme(String themeName) {
return themeSource.getTheme(themeName);
}
Expand Down
4 changes: 4 additions & 0 deletions grails-web-core/src/main/groovy/grails/web/servlet/context/GrailsWebApplicationContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
* A WebApplicationContext that extends StaticApplicationContext to allow for programmatic
* configuration at runtime. The code is adapted from StaticWebApplicationContext.
*
* <p>Note: The {@link ThemeSource} interface implementation is deprecated since Grails 7.1 and
* will be removed in Grails 8.0.0. Spring's theme support is deprecated in Spring Boot 3 and
* removed in Spring Boot 4.
*
* @author Graeme
* @since 0.3
*/
Expand Down
Loading