fix: fix flaky scaffolding Geb tests and User.getAuthorities() bug

grails-test-examples/scaffolding/grails-app/domain/com/example/User.groovy

@@ -56,7 +56,14 @@ class User implements UserDetails {
 
     @Override
     Collection<? extends GrantedAuthority> getAuthorities() {
-        roles.split('').collect { new SimpleGrantedAuthority(it) }
+        if (!roles) {
+            return Collections.emptyList()
+        }
+        roles
+                .split(',')
+                .collect { it.trim() }
+                .findAll { it }
+                .collect { new SimpleGrantedAuthority(it) }
     }
 
     @Override

grails-test-examples/scaffolding/src/integrationTest/groovy/com/example/UserCommunityControllerSpec.groovy

@@ -28,7 +28,7 @@ import grails.testing.mixin.integration.Integration
 @Integration
 class UserCommunityControllerSpec extends ContainerGebSpec {
 
-    void setup() {
+    private void loginAsTestUser() {
         to(LoginPage).login()
     }
 
@@ -42,9 +42,10 @@ class UserCommunityControllerSpec extends ContainerGebSpec {
 
     void "User list"() {
         when:
+        loginAsTestUser()
         def page = to(CommunityUserListPage)
 
         then:
         !page.scaffoldTable
     }
-}
+}

grails-test-examples/scaffolding/src/integrationTest/groovy/com/example/UserControllerSpec.groovy

@@ -28,7 +28,7 @@ import grails.testing.mixin.integration.Integration
 @Integration
 class UserControllerSpec extends ContainerGebSpec {
 
-    void setup() {
+    private void loginAsTestUser() {
         to(LoginPage).login()
     }
 
@@ -42,9 +42,10 @@ class UserControllerSpec extends ContainerGebSpec {
 
     void "User list"() {
         when:
+        loginAsTestUser()
         to(UserListPage)
 
         then:
         $('table.scaffold')
     }
-}
+}