[#11513] fix(catalog-mysql): Fix MySQL catalog incompatible with MariaDB due to case-sensitive CURRENT_TIMESTAMP check - #11510
Merged
Conversation
Contributor
|
If this is a fix, we should have an issue. Could u create an issue first? |
Contributor
Author
No, I just encountered this issue and made the necessary changes before submitting it directly |
Contributor
Author
Do I need to add an issue? |
Contributor
yes. |
Contributor
Author
|
Code Coverage Report
Files
|
Contributor
|
@a19920714liou |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11513
What changes were proposed in this pull request?
Changed the
CURRENT_TIMESTAMPcomparison inMysqlColumnDefaultValueConverterfrom case-sensitivestartsWithto case-insensitiveStringUtils.startsWithIgnoreCase.Why are the changes needed?
MariaDB returns default values with different casing (e.g.,
current_timestampin lowercase) compared to MySQL (e.g.,CURRENT_TIMESTAMPin uppercase). The existingString.startsWith()check is case-sensitive, which causes it to fail when connecting to a MariaDB database via the MySQL catalog, resulting in incorrect default value parsing.Does this PR introduce any user-facing change?
No user-facing API changes. This fix ensures MariaDB users can correctly use the MySQL catalog with proper default value handling.
How was this patch tested?
Manually tested by connecting the MySQL catalog to a MariaDB instance and verifying that columns with
CURRENT_TIMESTAMPas default value are correctly parsed.