[#10269] fix(core): prevent fileset privilege removal on failed drop - #12582
Open
s4ravanan wants to merge 6 commits into
Open
[#10269] fix(core): prevent fileset privilege removal on failed drop#12582s4ravanan wants to merge 6 commits into
s4ravanan wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#10269] fix(core): prevent fileset privilege removal on failed drop
What changes were proposed in this pull request?
Updated
FilesetHookDispatcher.dropFilesetto remove authorization privileges only when the delegated fileset drop succeeds.Added a regression test verifying that privileges are not removed when the delegate returns
false.Why are the changes needed?
When
dropFilesetreturnedfalse, authorization privileges were still removed. This could leave authorization state inconsistent with metadata state when the fileset was not deleted.Fix: #10269
Does this PR introduce any user-facing change?
No. This is an internal authorization consistency fix and does not change any public APIs or configuration properties.
How was this patch tested?
The following focused tests passed: