GUACAMOLE-2281: Add WebAuthn passthrough relay over req/done/cancel.#1218
Open
aleitner wants to merge 1 commit into
Open
GUACAMOLE-2281: Add WebAuthn passthrough relay over req/done/cancel.#1218aleitner wants to merge 1 commit into
aleitner wants to merge 1 commit into
Conversation
eugen-keeper
suggested changes
Jun 2, 2026
aleitner
force-pushed
the
GUACAMOLE-2281-webauthn-passthrough
branch
4 times, most recently
from
30fa8e1 to
7d9d4ca
Compare
eugen-keeper
approved these changes
Jun 4, 2026
bbennett-ks
reviewed
Jun 8, 2026
bbennett-ks
left a comment
bbennett-ks
left a comment
Contributor
There was a problem hiding this comment.
Noticed this reviewing the server side.
bbennett-ks
suggested changes
Jun 8, 2026
aleitner
force-pushed
the
GUACAMOLE-2281-webauthn-passthrough
branch
2 times, most recently
from
26d3fdf to
bf1a524
Compare
aleitner
force-pushed
the
GUACAMOLE-2281-webauthn-passthrough
branch
2 times, most recently
from
5b8e72c to
d40302f
Compare
Adds a WebAuthn passthrough relay that runs ceremonies on the user's local authenticator on behalf of a remote session. The server opens an inbound auth-challenge stream carrying the ceremony request body; the relay runs the WebAuthn ceremony and replies on an outbound auth-response stream. Updates to guacamole-common-js (Client.js): - sendAuthChallenge and sendAuthResponse methods returning a Guacamole.OutputStream the caller writes the body to. - onauthchallenge and onauthresponse events firing with (stream, mimetype, challengeId) for inbound streams. - Matching auth-challenge and auth-response instruction handlers. Updates to the Angular client: - ManagedClient routes inbound auth-challenge streams to ManagedWebAuthn based on mimetype (application/x-webauthn-create+json or application/x-webauthn-get+json), acking unsupported mimetypes. - ManagedWebAuthn assembles the challenge body off the stream, runs the ceremony via the existing webAuthnService under an AbortController keyed by challenge_id, and writes the credential or error JSON back on an auth-response stream. - On tunnel CLOSED, abortAll dismisses the local authenticator UI for any ceremonies left in flight.
aleitner
force-pushed
the
GUACAMOLE-2281-webauthn-passthrough
branch
from
d40302f to
d8de0f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new generic request/response RPC primitive to the Guacamole protocol in the form of three instructions: "req", "done", and "cancel". A "req" instruction initiates a typed request with a correlation id, a method name (by convention namespaced like "."), and an opaque payload. The receiving side settles the request with a "done" instruction carrying the same id and a status/payload, or either side may issue a "cancel" with the matching id to abort. The instructions themselves carry no WebAuthn-specific semantics, leaving room for other RPC-style features to share the same plumbing.
Adds the JavaScript surface for the new primitive on guacamole-common-js (Guacamole.Client.sendReq/sendDone/sendCancel and matching onreq/ondone/ oncancel events), plus a generic request handler registry on ManagedClient (registerRequestHandler/detachRequestHandler) that dispatches inbound "req" instructions to per-method-name handlers.
Implements WebAuthn passthrough as the first consumer: a new "webauthn" Angular module exposes a webAuthnService that performs ceremonies against the user's local authenticator with the remoteDesktopClientOverride extension, and a ManagedWebAuthn type wires "webauthn.create" and "webauthn.get" request handlers into ManagedClient, sending the resulting credential or error back via "done". A small status panel in the connection menu surfaces in-flight and last-ceremony state.
Requires the user's local browser to permit the
remoteDesktopClientOverride extension for the application's origin (typically administered via the Chromium
WebAuthenticationRemoteDesktopAllowedOrigins enterprise policy). The relay surfaces a clear "policy blocked" indication in the connection menu when this is missing.
This change is the client-side half of the relay. The server-side machinery that emits "req" instructions for WebAuthn ceremonies is the responsibility of individual protocol plugins.
Guacamole Server PR