-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17713. [ARR] Throtting asynchronous calls for each nameservice. #7304
Conversation
8efd978
to
616d707
Compare
💔 -1 overall
This message was automatically generated. |
54fa4eb
to
0cdc544
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@Hexiaoqiao @KeeProMise Sir, PTAL when you have free time. Thanks a lot. |
616d707
to
15cc381
Compare
c216b47
to
b8a3d07
Compare
💔 -1 overall
This message was automatically generated. |
82bccee
to
ad83682
Compare
b8a3d07
to
306f2ea
Compare
306f2ea
to
e5b9d0d
Compare
🎊 +1 overall
This message was automatically generated. |
Hi, @Hexiaoqiao @KeeProMise , pipeline builds successfully, could you help review this PR when have free time ? Thanks a lot. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @hfutatzhanghb thanks for your contribution, leave some comments.
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
...rc/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Add a new unit test class, let's wait Yetus. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's wait for 2 days. If no one else comments, I will merge it.
@hfutatzhanghb thanks for your contribution! |
@KeeProMise Thanks a lot for reviewing and merging!!! |
…pache#7304). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <[email protected]>
Description of PR
Throtting asynchronous calls for each nameservice.