HDFS-17714. MockResolver#removeLocation should also remove src path.#7313
Merged
KeeProMise merged 1 commit intoapache:trunkfrom Mar 21, 2025
Merged
HDFS-17714. MockResolver#removeLocation should also remove src path.#7313KeeProMise merged 1 commit intoapache:trunkfrom
KeeProMise merged 1 commit intoapache:trunkfrom
Conversation
|
🎊 +1 overall
This message was automatically generated. |
8a23747 to
c3846c7
Compare
|
🎊 +1 overall
This message was automatically generated. |
Member
|
Let's wait for two days to see if anyone else has more comments. |
Member
|
@hfutatzhanghb thanks for your contribution! |
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Mar 23, 2025
…pache#7313). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
When running TestRouterAsyncRpc in local, the testProxyMkdir always failed because of
BTW, the getListing source codes in my company has a little bit difference from the community's, but this is not important.
The path
/mntsnapshotis only appeared in testManageSnapshot, after diving into this problem, i found the reason is MockResolver#removeLocation only remove locations of a source path. This will leave the source path inMockResolver#locations.