HADOOP-19509. Add a config entry to make IPC.Client checkAsyncCall off by default.#7521
Merged
szetszwo merged 5 commits intoapache:trunkfrom Mar 21, 2025
Merged
HADOOP-19509. Add a config entry to make IPC.Client checkAsyncCall off by default.#7521szetszwo merged 5 commits intoapache:trunkfrom
szetszwo merged 5 commits intoapache:trunkfrom
Conversation
Member
Author
|
Hi, @KeeProMise , Please help review this PR when you have free time, Thanks ahead. And i will close HDFS-17758 #7501 . |
|
🎊 +1 overall
This message was automatically generated. |
Member
|
hi @hfutatzhanghb please pay attention to checkstyle. |
Member
Author
fixed, thanks a lot. |
szetszwo
reviewed
Mar 19, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@hfutatzhanghb , thanks for working on this! Please see the suggestion inlined.
|
|
||
| <!-- ipc properties --> | ||
| <property> | ||
| <name>ipc.client.async.calls.check.enable</name> |
Contributor
There was a problem hiding this comment.
Instead of adding another conf, how about having ipc.client.async.calls.max set to -1 for disabling it?
Member
Author
There was a problem hiding this comment.
Hi, @szetszwo . Thanks a lot for reviewing. Looks Good because it can prevent introduce a new configuraton.
We can modify code like this? Let's here what other people say and discuss it.
public boolean isAsyncCallCheckEabled() {
return maxAsyncCalls >= 0;
}Hi, @KeeProMise . Please cc. this, thanks a lot.
Member
Author
There was a problem hiding this comment.
Got it, Thanks all. Will push a new version later.
|
🎊 +1 overall
This message was automatically generated. |
szetszwo
approved these changes
Mar 20, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
@KeeProMise , would you like to take a look? Or we can merge this. |
Member
@hfutatzhanghb @szetszwo LGTM+1. |
KeeProMise
approved these changes
Mar 21, 2025
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-19509
Add a config entry to make IPC.Client checkAsyncCall off by default.
In my practice, when enable aysnc router rpc, we must adjust
ipc.client.async.calls.maxmuch larger. If not, we will get AsyncCallLimitExceededException exception frequently.The original purpose of method checkAsyncCall is to prevent Out-of-Memory from occurring on the client, we should make it not throttle router async rpc request. And we should make checkAsyncCall default by false unless user really know what they are doing and turn on this switch.
BTW, we use other mechanisms to prevent OOM from occurring on the hdfs router. please see HDFS-17713
How was this patch tested?
Add unit test.