HADOOP-19514: SecretManager logs at INFO in bin/hadoop calls

[cnauroth]

Description of PR

Switch to debug level for logging SecretManager configured algorithm and key length. I really wanted to do more improvements in this class, like resolving the configuration in a constructor instead of static initialization and potentially reusing a pre-existing Configuration instance. I couldn't find a way to do that while maintaining backward-compatibility, and the class is annotated as public.

How was this patch tested?

On trunk, build the distro:

mvn -o -Pdist -Dtar -DskipTests -DskipShade -Dmaven.javadoc.skip=true clean package

Reproduce the bug:

cnauroth@d9699e10bb20:/tmp/dist/hadoop-3.5.0-SNAPSHOT$ bin/hadoop s3guard -D fs.s3a.delegation.token.binding=org.apache.hadoop.fs.s3a.auth.delegation.FullCredentialsTokenBinding bucket-info s3a://foo
...
2025-03-25 19:57:26,731 INFO token.SecretManager: Selected hash algorithm: HmacSHA1
2025-03-25 19:57:26,732 INFO token.SecretManager: Selected hash key length:64
...

Apply this patch, rebuild the distro and retest. The SecretManager logs don't appear. You can get them back by explicitly enabling debug logging:

cnauroth@d9699e10bb20:/tmp/dist/hadoop-3.5.0-SNAPSHOT$ bin/hadoop --loglevel DEBUG s3guard -D fs.s3a.delegation.token.binding=org.apache.hadoop.fs.s3a.auth.delegation.FullCredentialsTokenBinding bucket-info s3a://foo
...
2025-03-25 21:29:21,476 DEBUG token.SecretManager: Selected hash algorithm: HmacSHA1
2025-03-25 21:29:21,476 DEBUG token.SecretManager: Selected hash key length:64
...

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	14m 9s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 15s		trunk passed
+1 💚	compile	15m 23s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	14m 0s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	checkstyle	1m 19s		trunk passed
+1 💚	mvnsite	1m 39s		trunk passed
+1 💚	javadoc	1m 15s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 55s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	spotbugs	2m 32s		trunk passed
+1 💚	shadedclient	35m 40s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 53s		the patch passed
+1 💚	compile	14m 55s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	14m 55s		the patch passed
+1 💚	compile	13m 29s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	javac	13m 29s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 10s		the patch passed
+1 💚	mvnsite	1m 36s		the patch passed
+1 💚	javadoc	1m 11s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 54s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	spotbugs	2m 39s		the patch passed
+1 💚	shadedclient	35m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	15m 10s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 4s		The patch does not generate ASF License warnings.
		211m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7537/1/artifact/out/Dockerfile
GITHUB PR	#7537
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 6c2e714cad3e 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / b562ce1
Default Java	Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7537/1/testReport/
Max. process+thread count	1271 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7537/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[steveloughran]

+1

[cnauroth]

I committed this to trunk. Thank you for the reviews, @slfan1989 and @steveloughran .

[szetszwo]

@cnauroth , thanks for working on this!

@slfan1989 , @steveloughran , thanks for reviewing this!

You guys are very fast! I was going to submit a PR and found that it had been already done.

[cnauroth]

@cnauroth , thanks for working on this!

@slfan1989 , @steveloughran , thanks for reviewing this!

You guys are very fast! I was going to submit a PR and found that it had been already done.

Happy to help, @szetszwo !