Backport "HBASE-29103 Avoid excessive allocations during reverse scanning when …" to branch-2.5

[jbewing]

…seeking to next row (#6643)

cc @rmdmattingly

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 2s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	4m 27s		branch-2.5 passed
+1 💚	compile	3m 14s		branch-2.5 passed
+1 💚	checkstyle	0m 51s		branch-2.5 passed
+1 💚	spotbugs	2m 23s		branch-2.5 passed
+1 💚	spotless	0m 59s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 38s		the patch passed
+1 💚	compile	2m 57s		the patch passed
+1 💚	javac	2m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 41s		the patch passed
+1 💚	spotbugs	2m 1s		the patch passed
+1 💚	hadoopcheck	26m 24s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚	spotless	0m 57s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 14s		The patch does not generate ASF License warnings.
		51m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6831
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 9bba78528210 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / d2946e5
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 24s		branch-2.5 passed
+1 💚	compile	0m 49s		branch-2.5 passed
+1 💚	javadoc	0m 27s		branch-2.5 passed
+1 💚	shadedjars	6m 22s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 6s		the patch passed
+1 💚	compile	0m 50s		the patch passed
+1 💚	javac	0m 50s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	6m 22s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	201m 47s		hbase-server in the patch passed.
		228m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6831
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 10ef97a239bf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / d2946e5
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/testReport/
Max. process+thread count	4268 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	4m 2s		branch-2.5 passed
+1 💚	compile	1m 2s		branch-2.5 passed
+1 💚	javadoc	0m 32s		branch-2.5 passed
+1 💚	shadedjars	7m 50s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 58s		the patch passed
+1 💚	compile	1m 29s		the patch passed
+1 💚	javac	1m 29s		the patch passed
+1 💚	javadoc	0m 45s		the patch passed
+1 💚	shadedjars	9m 10s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	260m 28s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		297m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6831
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux dd4afa0b07ac 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / d2946e5
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/testReport/
Max. process+thread count	4373 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 13s		branch-2.5 passed
+1 💚	compile	0m 53s		branch-2.5 passed
+1 💚	javadoc	0m 28s		branch-2.5 passed
+1 💚	shadedjars	6m 25s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s		the patch passed
+1 💚	compile	1m 14s		the patch passed
+1 💚	javac	1m 14s		the patch passed
+1 💚	javadoc	0m 44s		the patch passed
+1 💚	shadedjars	8m 19s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	270m 22s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		301m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6831
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 3beeb683a9c1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / d2946e5
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/testReport/
Max. process+thread count	4136 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6831/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[jbewing]

Test failures also appear to be unrelated here as well. Here were the failing tests

precommit checks / yetus jdk17 hadoop3 checks / org.apache.hadoop.hbase.regionserver.TestClearRegionBlockCache.testClearBlockCache[1: bucket] | 13 sec | 1
-- | -- | --
precommit checks / yetus jdk17 hadoop3 checks / org.apache.hadoop.hbase.regionserver.wal.TestFSHLog.testWALClosureFailureAndCleanup | 1.4 sec | 1
precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.region.TestMasterRegionWALCleaner.test | 11 sec | 1
precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.testReplicationOfEmptyWALSurroundedNonEmptyWAL