HBASE-29244 Support admin users acl setting with LDAP (Web UI only) #6923

NihalJain · 2025-04-23T07:59:28Z

No description provided.

NihalJain · 2025-04-25T10:15:06Z

Failure is unrelated!

NihalJain · 2025-05-07T12:11:32Z

I have verified this change in a distributed setup with ldap, works as expected, only admin user can access privileged pages in web ui!

Please review @Apache9 @ndimiduk @stoty @PDavid

PDavid

Many thanks Nihal, looks very clean and nice to me. 👍

hbase-http/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java

hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestLdapAdminACL.java

hbase-http/src/test/java/org/apache/hadoop/hbase/http/LdapServerTestBase.java

hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestProxyUserSpnegoHttpServer.java

src/main/asciidoc/_chapters/security.adoc

NihalJain · 2025-05-15T21:40:10Z

Hey @PDavid thanks for your reviews. Will look at the review comments and come back with a PR update soon!

NihalJain · 2025-05-19T09:45:44Z

Hey @PDavid thanks for your reviews. Will look at the review comments and come back with a PR update soon!

Address review comments by @PDavid with 3e2891b

Please review!

PDavid

Many thanks Nihal Jain for the additional improvements. 👍

Apache-HBase · 2025-05-20T02:07:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	1m 42s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 32s		master passed
+1 💚	compile	7m 58s		master passed
+1 💚	checkstyle	1m 10s		master passed
+1 💚	spotbugs	7m 51s		master passed
+0 🆗	refguide	2m 31s		branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	8m 4s		the patch passed
-0 ⚠️	javac	8m 4s	/results-compile-javac-root.txt	root generated 4 new + 1270 unchanged - 2 fixed = 1274 total (was 1272)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 12s		the patch passed
+1 💚	spotbugs	8m 0s		the patch passed
+0 🆗	refguide	2m 3s		patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	11m 55s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		69m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6923
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless refguide
uname	Linux 91848e0865ba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3e2891b`
Default Java	Eclipse Adoptium-17.0.11+9
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6923/6/yetus-general-check/output/branch-site/book.html
refguide	https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6923/6/yetus-general-check/output/patch-site/book.html
Max. process+thread count	189 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-05-20T05:56:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 12s		master passed
+1 💚	compile	2m 15s		master passed
+1 💚	javadoc	2m 7s		master passed
+1 💚	shadedjars	5m 58s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	2m 11s		the patch passed
+1 💚	javac	2m 11s		the patch passed
+1 💚	javadoc	2m 8s		the patch passed
+1 💚	shadedjars	5m 53s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	234m 24s	/patch-unit-root.txt	root in the patch failed.
		267m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6923
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 037075685beb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3e2891b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/6/testReport/
Max. process+thread count	5944 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk

Nice one @NihalJain !

NihalJain · 2025-05-20T17:15:34Z

Failures are not related.

NihalJain · 2025-05-20T17:20:07Z

Will merge this soon, but let me get other related LDAP change to branch-2 first, #5680

Apache-HBase · 2025-05-27T10:39:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s		master passed
+1 💚	compile	2m 17s		master passed
+1 💚	javadoc	3m 20s		master passed
+1 💚	shadedjars	6m 49s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s		the patch passed
+1 💚	compile	2m 54s		the patch passed
+1 💚	javac	2m 54s		the patch passed
+1 💚	javadoc	2m 59s		the patch passed
+1 💚	shadedjars	6m 37s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	329m 58s	/patch-unit-root.txt	root in the patch failed.
		368m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6923
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux e41a3184c564 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3e2891b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/2/testReport/
Max. process+thread count	5066 (vs. ulimit of 30000)
modules	C: hbase-http . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6923/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…6923) Signed-off-by: Nick Dimiduk <[email protected]> Reviewed-by: Dávid Paksy <[email protected]> (cherry picked from commit 06a74f1)

…pache#6923) Signed-off-by: Nick Dimiduk <[email protected]> Reviewed-by: Dávid Paksy <[email protected]> (cherry picked from commit 06a74f1)

…pache#6923) - Exclude test files which do not work with hadoop-2 Signed-off-by: Nick Dimiduk <[email protected]> Reviewed-by: Dávid Paksy <[email protected]> (cherry picked from commit 06a74f1)

…6923) (#7053) * Exclude test files which do not work with hadoop-2 Signed-off-by: Nick Dimiduk <[email protected]> Reviewed-by: Dávid Paksy <[email protected]> (cherry picked from commit 06a74f1)

…6923) (#7054) * Exclude test files which do not work with hadoop-2 Signed-off-by: Nick Dimiduk <[email protected]> Reviewed-by: Dávid Paksy <[email protected]> (cherry picked from commit 06a74f1)

…6923) (#7055) * Exclude test files which do not work with hadoop-2 Signed-off-by: Nick Dimiduk <[email protected]> Reviewed-by: Dávid Paksy <[email protected]> (cherry picked from commit 06a74f1)

This comment has been minimized.

Sign in to view

NihalJain force-pushed the HBASE-29244 branch from 8b899a9 to 8086853 Compare April 24, 2025 22:09

This comment has been minimized.

Sign in to view

PDavid approved these changes May 8, 2025

View reviewed changes

NihalJain added 4 commits May 19, 2025 15:12

HBASE-29244 Support admin users acl setting with LDAP (Web UI only)

10da6eb

HBASE-29244 Support admin users acl setting with LDAP (Web UI only)

ef0d4d4

Fix tests, cleanup code

7dc8e62

* Address review comments

3e2891b

NihalJain force-pushed the HBASE-29244 branch from 8086853 to 3e2891b Compare May 19, 2025 09:42

PDavid approved these changes May 19, 2025

View reviewed changes

ndimiduk approved these changes May 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

NihalJain merged commit 06a74f1 into apache:master May 31, 2025
1 check failed

NihalJain mentioned this pull request May 31, 2025

HBASE-29244 Support admin users acl setting with LDAP (Web UI only) (#6923) #7053

Merged

NihalJain mentioned this pull request May 31, 2025

HBASE-29244 Support admin users acl setting with LDAP (Web UI only) (… #7054

Merged

NihalJain mentioned this pull request May 31, 2025

HBASE-29244 Support admin users acl setting with LDAP (Web UI only) (… #7055

Merged

HBASE-29244 Support admin users acl setting with LDAP (Web UI only) #6923

HBASE-29244 Support admin users acl setting with LDAP (Web UI only) #6923

Uh oh!

Conversation

NihalJain commented Apr 23, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain commented Apr 25, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

NihalJain commented May 7, 2025

Uh oh!

PDavid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NihalJain commented May 15, 2025

Uh oh!

NihalJain commented May 19, 2025

Uh oh!

PDavid left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

Apache-HBase commented May 20, 2025

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

NihalJain commented May 20, 2025

Uh oh!

NihalJain commented May 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented May 27, 2025

Uh oh!

Uh oh!

Uh oh!