Skip to content

HBASE-29292 Automatically reassign regions when WALs and ZK go missing #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5,881 commits into from

Conversation

taklwu
Copy link
Contributor

@taklwu taklwu commented May 8, 2025

sorry for the long delay from the comments of #2114 that peter asked changes for HBASE-24282.

This patch addresses the previous comments by introducing a new feature flag, hbase.master.assign.regions.on.unknown.servers, to handle cases where an HBase cluster is restarted after WAL and ZooKeeper nodes have been removed. This is particularly useful when recreating an HBase cluster on cloud storage, where HDFS and ZooKeeper are always initialized fresh.

2005hithlj and others added 30 commits July 31, 2024 09:12
…pache#6146)

* Sync code as per irb 1.4.2
* Also provide option to try irb's new functionalities for colorize and autocomplete

Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>

(cherry picked from commit 6788ff4)
… from output tarball (apache#6157) (apache#6159)

Signed-off-by: Duo Zhang <[email protected]>

(cherry picked from commit 98e7e1b)
…eTransition if procedure is initialised by next Active master (apache#6136)

Added masterActiveTime as fencing token for remote procedures

Signed-off-by: Duo Zhang <[email protected]>
Reviewed-by: Aman Poonia <[email protected]>
…rable state for the given backup (apache#6088)

Co-authored-by: Ray Mattingly <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
Reviewed-by: Vineet Kumar Maheshwari <[email protected]>
…ks in a defined order (apache#6168)" to branch-2 (apache#6200)

Signed-off-by: Nick Dimiduk <[email protected]>
Co-authored-by: Charles Connell <[email protected]>
…fined order (apache#6168)

Signed-off-by: Nick Dimiduk <[email protected]>
Co-authored-by: Charles Connell <[email protected]>
…ks a connection to ZooKeeper (apache#6207)

Signed-off-by: Duo Zhang <[email protected]>
Co-authored-by: rodenli <[email protected]>
…procedure.jsp while Master is initializing (apache#6210)

Signed-off-by: Duo Zhang <[email protected]>
…apache#6187) (apache#6214)

Co-authored-by: WangXin <[email protected]>
Co-authored-by: wangxin <[email protected]>

Signed-off-by: Nihal Jain <[email protected]>
(cherry picked from commit b161ad5)
…ile unassigning a region (apache#6197) (apache#6217)

Signed-off-by: Wellington Chevreuil <[email protected]>
(cherry picked from commit 888e4dd)
…pache#6218) (apache#5607)

- Also handle changes required for hadoop-2 assembly

Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
(cherry picked from commit b6394b1)
…addendum: sync protobuf 3 version to hbase-thidparty)
…apache#6226) (apache#6238)

Co-authored-by: wangxin <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 3390195)

Co-authored-by: WangXin <[email protected]>
Apache9 and others added 16 commits April 20, 2025 13:57
…StoreScanner (apache#6901)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit abc8b43)
…sisted (apache#6916) (apache#6910)

Signed-off-by: Andrew Purtell <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Reid Chan <[email protected]>
Signed-off-by: gvprathyusha6 <[email protected]>
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>

The HBase backup mechanism keeps track of which HFiles
were bulk loaded, so they can be included in incremental
backups.

Before this ticket, these bulk load records were only
deleted when an incremental backup is created. This
commit adds 2 more locations:

1) after a full backup. Since a full backup already
captures all data, this meant that unnecessary HFiles
were being included in the next incremental backup.

2) after a table delete/truncate/CF-deletion. Previously,
if an HFile was loaded before a table was cleared, the next
incremental backup would effectively still include the
HFile. This lead to incorrect data being restored.

This commit also completely refactors & simplifies the
test for this functionality.

Co-authored-by: DieterDP <[email protected]>
)

Co-authored-by: Hernan Gelaf-Romer <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Ray Mattingly <[email protected]>
…t ClassLoader (apache#6918)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit bd30367)
…le (apache#6842) (apache#6929)

Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Nihal Jain <[email protected]>
Co-authored-by: Ray Mattingly <[email protected]>
…operties (apache#6948)

Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
(cherry picked from commit ae40069)
…Changed behavior (apache#6900)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 99bd5b5)
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 21s branch-2 passed
+1 💚 compile 3m 7s branch-2 passed
+1 💚 checkstyle 0m 40s branch-2 passed
+1 💚 spotbugs 1m 39s branch-2 passed
+1 💚 spotless 0m 50s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 15s the patch passed
+1 💚 compile 2m 59s the patch passed
+1 💚 javac 2m 59s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 35s the patch passed
+1 💚 spotbugs 1m 42s the patch passed
+1 💚 hadoopcheck 17m 4s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 48s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
38m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6968/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6968
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 8d4967b8cdef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 028d0f2
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6968/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 26s branch-2 passed
+1 💚 compile 0m 41s branch-2 passed
+1 💚 javadoc 0m 23s branch-2 passed
+1 💚 shadedjars 5m 17s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 28s the patch passed
+1 💚 compile 0m 41s the patch passed
+1 💚 javac 0m 41s the patch passed
+1 💚 javadoc 0m 24s the patch passed
+1 💚 shadedjars 5m 16s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 214m 13s hbase-server in the patch passed.
236m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6968/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6968
Optional Tests javac javadoc unit compile shadedjars
uname Linux d985ad25b7d8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 028d0f2
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6968/2/testReport/
Max. process+thread count 4016 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6968/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@taklwu taklwu changed the base branch from branch-2 to master May 9, 2025 18:08
@taklwu taklwu closed this May 9, 2025
@taklwu
Copy link
Contributor Author

taklwu commented May 9, 2025

let me reopen a new one against master #6981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.