HIVE-28853: SharedWorkOptimizer should always consider MapJoin operators' InMemoryDataSize. #5717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
Outdated
Show resolved
Hide resolved
SourabhBadhya
approved these changes
May 2, 2025
kasakrisz
reviewed
May 12, 2025
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
ngsg
force-pushed
the
HIVE-28853-fix-extractSharedOptimizationInfoForRoot
branch
from
ec5d1ba to
1de8b9a
Compare
|
@kasakrisz , I have updated the patch according to your review. Could you review the changes again? |
kasakrisz
approved these changes
May 15, 2025
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
|
@ngsg |
|
@kasakrisz , I have updated the qfile output. It looks like I forgot to compile the project after rebase. Thanks for pointing that out. |
|
@ngsg |
ngsg
force-pushed
the
HIVE-28853-fix-extractSharedOptimizationInfoForRoot
branch
from
0858fa4 to
0d61ae0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The patch modifies
SharedWorkOptimizer.extractSharedOptimizationInfoForRootto consider MapJoin's inMemoryDataSize.Why are the changes needed?
Current SharedWorkOptimizer may produce a vertex with a large number of MapJoins, potentially causing the MapJoin HashTables to exceed available memory. This patch prevents such misbehaviour.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
I tested the patch by qfile test.