HIVE-28957: Enhance TestHiveMetaStoreAuthorizer #5819
+355
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the TestHiveMetaStoreAuthorizer tests to verify that proper privilege objects are generated and filter contexts are applied as expected. Key changes include switching from the DummyHiveAuthorizerFactory to a dedicated MockHiveAuthorizerFactory, adding additional authorization failure checks with explicit fail messages, and introducing a new mock filter hook (MockMetaStoreFilterHook) to validate ownership-based filtering in metadata operations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java | Updated tests to use a mock authorizer, added privilege capture and ownership filtering tests, and modified configuration to use the new mock classes. |
| ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/MockMetaStoreFilterHook.java | Introduced a mock filter hook implementation to verify that filtering logic based on ownership behaves as expected. |
...ache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enhance TestHiveMetaStoreAuthorizer to verify that the correct privilege objects are created for each operation and ensure the appropriate filter contexts are constructed and applied
Why are the changes needed?
Existing TestHiveMetaStoreAuthorizer uses DummyHiveAuthorizerFactory, which bypasses validation of the real HiveMetaStoreAuthorizer's filtering behavior.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Regression tests, unit tests