Check storage-credentials before config in table response#2600
Closed
coca-alex wants to merge 11 commits intoapache:mainfrom
Closed
Check storage-credentials before config in table response#2600coca-alex wants to merge 11 commits intoapache:mainfrom
coca-alex wants to merge 11 commits intoapache:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2594
Rationale for this change
According to the Iceberg specification, clients must first check whether the respective credentials exist in the
storage-credentialsfield before checking theconfigfor credentials and choose the most specific prefix if several credentials of the same type are available.Are these changes tested?
Yes, I added two tests:
test_storage_credentials_over_configandtest_config_when_no_storage_credentialsto verify the behavior.Are there any user-facing changes?
No