Throw on {write.folder-storage.path,write.object-storage.path} properties
#12315
Conversation
…rties Another way of warning non-Java users about the deprecated properties - `write.folder-storage.path` - `write.object-storage.path` This will only warn when `write.data.path` is not set. So hopefuly the number in the logs will be limited.
Fokko
force-pushed
the
fd-warn-on-deprecations
branch
from
65ec291 to
6b8db34
Compare
Fokko
force-pushed
the
fd-warn-on-deprecations
branch
from
6b8db34 to
216a04a
Compare
There was a problem hiding this comment.
I wonder whether the now "illegal" properties should also be caught when setting namespace/table/view properties, so that it becomes impossible to set those properties (and run into hard failures when accessing data).
There seem to be more usages of OBJECT_STORE_PATH and WRITE_FOLDER_STORAGE_LOCATION - e.g. IcebergToGlueConverter and RewriteTablePathUtil
Fokko
changed the title
{write.folder-storage.path,write.object-storage.path} properties{write.folder-storage.path,write.object-storage.path} properties
I think we can just remove them with 2.0, where they are used it is harmless (removing them when you copy a table, rewriting them when you write the base location, etc). |
Fokko
force-pushed
the
fd-warn-on-deprecations
branch
from
ba0871f to
2ae5fca
Compare
I think that would quite useful to prevent users from putting in any of the "illegal" properties. WDYT? |
I'm not a fan of it, because I think it is very hard to enforce across implementations. For example, we don't support the ones that were deprecated in this PR in PyIceberg/Rust/Go, let other vendors. Since we need to maintain this list, we're also not able to completely remove them at some point. |
Fokko
force-pushed
the
fd-warn-on-deprecations
branch
from
16fa9b6 to
bdd63f5
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
Another way of warning non-Java users about the deprecated properties
write.folder-storage.pathwrite.object-storage.pathHas been deprecated since 0.13.0 in #3094