Core: Apply correct metric configs in GenericAppenderFactory #12366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The specific cause of the issue can be referenced in apache/amoro#3273 |
XBaith
force-pushed
the
fix-generic-appender-metric-configs
branch
2 times, most recently
from
52ed81c to
c9dfece
Compare
pvary
reviewed
Feb 21, 2025
XBaith
force-pushed
the
fix-generic-appender-metric-configs
branch
from
c9dfece to
d0ac6f4
Compare
XBaith
force-pushed
the
fix-generic-appender-metric-configs
branch
from
d0ac6f4 to
00f3e02
Compare
pvary
reviewed
Feb 21, 2025
pvary
reviewed
Feb 21, 2025
pvary
reviewed
Feb 21, 2025
Comment on lines
121
to
127
| MetricsConfig metricsConfig; | ||
| if (table == null) { | ||
| metricsConfig = MetricsConfig.fromProperties(config); | ||
| } else { | ||
| metricsConfig = MetricsConfig.forTable(table); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a bit questionable for me.
Do we really want to disregard the config properties specifically set by the set/setAll method if the table has provided?
We should decide on the expected behavior and make sure that we don't get wrong configuration. Maybe by throwing an exception in the set methods when the table is set?
|
Please add some tests to ensure that the metrics are honored if the table is set |
XBaith
force-pushed
the
fix-generic-appender-metric-configs
branch
from
5eeeabd to
27263c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DataWriter created using GenericAppenderFactory in the application does not configure metric writing behavior according to the table's properties.
Based on previous modifications, such as FlinkAppenderFactory, this class should also invoke the correct API to configure the relevant properties